Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable clang-tidy-review check in linux github action #169

Open
birschick-bq opened this issue Jan 31, 2023 · 0 comments
Open

Enable clang-tidy-review check in linux github action #169

birschick-bq opened this issue Jan 31, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@birschick-bq
Copy link
Contributor

clang-tidy-check fails due to errors that shouldn't be a problem for our code. For example, even with compile_commands.json generated, clang-tidy-check still is unable to find boost/optional.hpp, which might be due to boost being outside of our project root folder. There might be more errors beside that.
Reference to clang-tidy-check error:

AC:

  • enable clang-tidy-check inside github workflow.
  • [optional] create a test PR with minor code/comment changes to see that clang-tidy-check does not fail
@birschick-bq birschick-bq added the enhancement New feature or request label Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant