Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transferEncoding for Streaming RequestBody with UnsignedPayload as True #5906

Open
wants to merge 4 commits into from

Conversation

joviegas
Copy link
Contributor

@joviegas joviegas commented Feb 26, 2025

Motivation and Context

The authType traits will be deprecated in favor of the unsignedPayload traits. Generators implementing this SEP must ignore the old traits if the new traits are present. If the new traits are not present, generators should fall back to using the old traits. The section above describes how backwards compatibility will be maintained.

Modifications

  • Thus we need to add or logic with opModel.isUnsignedPayload() while setting .transferEncoding(true) on Streaming request body.
  • Note that currently all the services use unsignedPayload and AythType :"V4_UNSIGNED_BODY" so there was no impact even without fix, this fix is done for future model updates that will use unsignedPayload and not d AythType :"V4_UNSIGNED_BODY"

Testing

  • Added codegen test

Screenshots (if appropriate)

License

  • I confirm that this pull request can be released under the Apache 2 license

@joviegas joviegas requested a review from a team as a code owner February 26, 2025 01:32
@joviegas joviegas enabled auto-merge February 26, 2025 23:27
@joviegas joviegas added this pull request to the merge queue Feb 27, 2025
Any commits made after this event will not be merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants