Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import evenstream library #5908

Open
wants to merge 2 commits into
base: feature/master/eventstream-import
Choose a base branch
from

Conversation

dagnir
Copy link
Contributor

@dagnir dagnir commented Feb 27, 2025

Motivation and Context

Import from awslabs/aws-eventstream-java@1e76ef4

aws-eventstream-java was meant as a reference implementation; this is a source import of this library so that we can customize it for our needs, e.g. changing or removing built-in validations.

Note this is the source for the same Maven version that we're currently depending on (1.0.1):

<eventstream.version>1.0.1</eventstream.version>

Modifications

Direct source import other than

  • Fixing checkstyle violations
  • Adding @SdkProtectedApi annotation to all classes.

Testing

  • There are existing tests from the source repo, they are passing.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

Import from awslabs/aws-eventstream-java@1e76ef4

`aws-eventstream-java` was meant as a reference implementation; this is
a source import of this library so that we can customize it for our
needs, e.g. changing or removing built-in validations.
@dagnir dagnir marked this pull request as ready for review February 27, 2025 00:20
@dagnir dagnir requested a review from a team as a code owner February 27, 2025 00:20
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
69.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@dagnir dagnir changed the base branch from master to feature/master/eventstream-import February 27, 2025 19:03
@dagnir dagnir force-pushed the dongie/import-evenstream-java branch from d94be8f to 985d39a Compare February 27, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants