From ff7442607b2aaf6ac4b85f7e535363a9a090b076 Mon Sep 17 00:00:00 2001 From: George Fu Date: Fri, 31 Jan 2025 11:01:53 -0500 Subject: [PATCH] chore(middleware-sdk-s3): unset SessionMode default value --- .../middleware-s3-express.integ.spec.ts | 17 +++++++++++++++++ .../middleware-sdk-s3/src/s3Configuration.ts | 1 - 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/packages/middleware-sdk-s3/src/s3-express/middleware-s3-express.integ.spec.ts b/packages/middleware-sdk-s3/src/s3-express/middleware-s3-express.integ.spec.ts index ac069197b867..df2e2c89540c 100644 --- a/packages/middleware-sdk-s3/src/s3-express/middleware-s3-express.integ.spec.ts +++ b/packages/middleware-sdk-s3/src/s3-express/middleware-s3-express.integ.spec.ts @@ -20,6 +20,23 @@ describe("middleware-s3-express", () => { }; describe(S3.name, () => { + it("should not send the x-amz-create-session-mode header", async () => { + const client = new S3({ region: "us-west-2", s3ExpressIdentityProvider }); + + requireRequestsFrom(client).toMatch({ + headers: { + "x-amz-create-session-mode": /undefined/, + }, + }); + + await client.getObject({ + Bucket: "aws-sdk-js-v3-test--usw2-az1--x-s3", + Key: "1", + }); + + expect.hasAssertions(); + }); + it("should default to CRC32 checksum when the request requires a checksum and none is specified", async () => { const client = new S3({ region: "us-west-2", s3ExpressIdentityProvider }); diff --git a/packages/middleware-sdk-s3/src/s3Configuration.ts b/packages/middleware-sdk-s3/src/s3Configuration.ts index 4072a01dcaa4..6dfd9d3544ec 100644 --- a/packages/middleware-sdk-s3/src/s3Configuration.ts +++ b/packages/middleware-sdk-s3/src/s3Configuration.ts @@ -82,7 +82,6 @@ export const resolveS3Config = ( s3ClientProvider().send( new CreateSessionCommandCtor({ Bucket: key, - SessionMode: "ReadWrite", }) ) ),