Skip to content

Commit

Permalink
Fix build (#783)
Browse files Browse the repository at this point in the history
* Update Node

* Update NVM

* Update corepack

* Add test action to ensure docker image builds

* Only run on pull requests since publish runs on main

* Update changelog
  • Loading branch information
kmcginnes authored Feb 7, 2025
1 parent ec7d6f5 commit 46372f5
Show file tree
Hide file tree
Showing 7 changed files with 31 additions and 7 deletions.
22 changes: 22 additions & 0 deletions .github/workflows/test_build_docker.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
name: Test build the Docker image

on:
workflow_dispatch:
pull_request:
branches:
- main

jobs:
test-build-docker-image:
runs-on: ubuntu-latest
permissions:
contents: read

steps:
- name: Checkout
uses: actions/checkout@v3

- name: Build Docker image
run: |
docker build .
docker build --build-arg NEPTUNE_NOTEBOOK=true .
2 changes: 1 addition & 1 deletion .github/workflows/unit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
strategy:
matrix:
node-version:
- 22.11.0
- 22.13.1
pnpm-version:
- 9.15.0
steps:
Expand Down
3 changes: 2 additions & 1 deletion Changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@
- Graph legend is now consistent with other panels
- **Updated** dependencies and remove unused dependencies
([#764](https://github.com/aws/graph-explorer/pull/764),
[#776](https://github.com/aws/graph-explorer/pull/776))
[#776](https://github.com/aws/graph-explorer/pull/776),
[#783](https://github.com/aws/graph-explorer/pull/783))

## Release 1.13.0

Expand Down
5 changes: 3 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ FROM amazonlinux:2023
ARG NEPTUNE_NOTEBOOK

ENV NVM_DIR=/root/.nvm
ENV NODE_VERSION=v22.11.0
ENV NODE_VERSION=v22.13.1
ENV NEPTUNE_NOTEBOOK=$NEPTUNE_NOTEBOOK
ENV HOME=/graph-explorer

Expand Down Expand Up @@ -37,11 +37,12 @@ WORKDIR /graph-explorer
RUN yum update -y && \
yum install -y tar gzip git findutils openssl && \
mkdir -p $NVM_DIR && \
curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.7/install.sh | bash && \
curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.40.1/install.sh | bash && \
source $NVM_DIR/nvm.sh && \
nvm install $NODE_VERSION && \
nvm alias default $NODE_VERSION && \
nvm use $NODE_VERSION && \
npm install --global corepack@latest && \
corepack enable && \
pnpm install && \
pnpm build && pnpm clean:dep && pnpm install --prod --ignore-scripts && \
Expand Down
2 changes: 1 addition & 1 deletion additionaldocs/development.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ environment variables to switch to HTTP.
### Requirements

- pnpm >=9.15.0
- node >=22.11.0
- node >=22.13.1

#### Node Version

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"license": "Apache-2.0",
"packageManager": "[email protected]",
"engines": {
"node": ">=22.11.0",
"node": ">=22.13.1",
"pnpm": "9.15.0"
},
"private": true,
Expand Down
2 changes: 1 addition & 1 deletion packages/graph-explorer/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "1.13.0",
"description": "Graph Explorer",
"engines": {
"node": ">=22.11.0"
"node": ">=22.13.1"
},
"type": "module",
"scripts": {
Expand Down

0 comments on commit 46372f5

Please sign in to comment.