Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AdvancedList #743

Merged
merged 3 commits into from
Jan 16, 2025
Merged

Remove AdvancedList #743

merged 3 commits into from
Jan 16, 2025

Conversation

kmcginnes
Copy link
Collaborator

@kmcginnes kmcginnes commented Jan 12, 2025

Description

The AdvancedList component was an overcomplicated component that boiled down to a list of rows that can be filtered by a search and used virtualization for large lists. The template for rows was overly restrictive and required a lot of plugin points to allow meaningful customization.

Instead of painstakingly converting it over to Tailwind, it was much easier and more reliable to rewrite the four remaining uses of AdvancedList.

The result is way less code and complexity with the same feature set or better. We now have much more control over how a row looks and what content it contains.

  • Added attribute count to node labels list in connection
  • Updated search field to use new input and rounded corners

Validation

  • Verified connection node labels list
  • Verified SPARQL namespaces (auto, common, custom)
Before After
before after
before after
before after

Related Issues

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0
    license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I have covered new added functionality with unit tests if necessary.
  • I have added an entry in the Changelog.md.

@kmcginnes kmcginnes force-pushed the remove-advanced-list branch from 83d0def to 1d45b70 Compare January 13, 2025 00:39
@kmcginnes kmcginnes marked this pull request as ready for review January 14, 2025 21:56
@kmcginnes kmcginnes force-pushed the remove-advanced-list branch from 9e7edc0 to e12edb8 Compare January 15, 2025 15:28
@kmcginnes kmcginnes force-pushed the remove-advanced-list branch from e12edb8 to 58eee08 Compare January 16, 2025 17:45
@andreachild
Copy link

LGTM

@kmcginnes kmcginnes merged commit 10e1225 into aws:main Jan 16, 2025
1 check passed
@kmcginnes kmcginnes deleted the remove-advanced-list branch January 16, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove AdvancedList
2 participants