Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add comments to summarize changes at top of each patch #12

Open
aws-spenceng opened this issue Mar 7, 2024 · 0 comments
Open

Add comments to summarize changes at top of each patch #12

aws-spenceng opened this issue Mar 7, 2024 · 0 comments

Comments

@aws-spenceng
Copy link
Contributor

aws-spenceng commented Mar 7, 2024 •
edited
Loading

For each patch in series, we should add comments at the top of each patch and explain what it's for and how to test the functionality

(03/08/24) Another link was added for webview.diff patch to evaluate script-src to explain how we made this change (see 2nd comment link below)

Original comment: #11 (comment)

2nd comment: https://github.com/aws/sagemaker-code-editor/pull/13/files#r1518235315
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aws-spenceng