Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate necessity of commit and date properties in product.ts #14

Open
aws-spenceng opened this issue Mar 8, 2024 · 0 comments
Open

Investigate necessity of commit and date properties in product.ts #14

aws-spenceng opened this issue Mar 8, 2024 · 0 comments

Comments

@aws-spenceng
Copy link
Contributor

In product.ts, there are additional properties that don't have an obvious utility in commit: "hellocommit", and date: "hellodate",. If they are not necessary, we should consider removing it altogether.

Original Github thread: https://github.com/aws/sagemaker-code-editor/pull/13/files#r1518226219
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aws-spenceng