Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HW optimized CRC32 implementation #82

Open
1 of 2 tasks
pbadari opened this issue Mar 14, 2024 · 1 comment
Open
1 of 2 tasks

HW optimized CRC32 implementation #82

pbadari opened this issue Mar 14, 2024 · 1 comment
Labels
feature-request New feature or enhancement. May require GitHub community feedback. p3 This is a minor priority issue

Comments

@pbadari
Copy link
Contributor

pbadari commented Mar 14, 2024

Describe the feature

Looking through the code (for Intel architecture), I see that aws_checksums_crc32() is only SW implementation. There is no hardware accelerated implementation (SSE4.2 or AVX512). However aws_checksums_crc32c() has HW accelerated implementation.

Is there a reason why CRC32 implementation is not hardware accelerated? There are no users for it?
Please let me know if there is interest.

Use Case

HW optimized CRC32 implementation for Intel architecture using AVX512.

Proposed Solution

I am working on AVX512 optimized CRC32c implementation (in AVX512 branch), I can easily modify it to support both CRC32 and CRC32c.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@pbadari pbadari added the feature-request New feature or enhancement. May require GitHub community feedback. label Mar 14, 2024
@jmklix
Copy link
Member

jmklix commented Mar 19, 2024

Yes, please make a PR if this is something that would be easy for you to add. We will make sure to review it.

@jmklix jmklix added the p3 This is a minor priority issue label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or enhancement. May require GitHub community feedback. p3 This is a minor priority issue
Projects
None yet
Development

No branches or pull requests

2 participants