Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce number of dependencies added by AWS CRT #333

Open
trivikr opened this issue Jul 7, 2022 · 2 comments
Open

Reduce number of dependencies added by AWS CRT #333

trivikr opened this issue Jul 7, 2022 · 2 comments
Labels
feature-request A feature should be added or improved. p3 This is a minor priority issue

Comments

@trivikr
Copy link
Member

trivikr commented Jul 7, 2022

Is your feature request related to a problem? Please describe.

Installing [email protected] adds 118 dependencies in node_modules as shown below.

$ mkdir test-aws-crt && cd test-aws-crt

$ test-aws-crt> npm init -y && npm install [email protected] --save-exact

$ test-aws-crt> find node_modules -type d -maxdepth 1 | wc -l
     118

$ test-aws-crt> ls -1 node_modules
@httptoolkit
@types
ansi
ansi-regex
are-we-there-yet
aws-crt
axios
balanced-match
base64-js
big-integer
binary
bl
bluebird
brace-expansion
buffer
buffer-from
buffer-indexof-polyfill
buffer-shims
buffers
camelcase
chainsaw
chownr
cliui
cmake-js
code-point-at
commist
concat-map
concat-stream
core-util-is
crypto-js
debug
decamelize
deep-extend
delegates
duplexer2
duplexify
end-of-stream
fastestsmallesttextencoderdecoder
follow-redirects
fs-extra
fs-minipass
fs.realpath
fstream
gauge
glob
graceful-fs
has-unicode
help-me
ieee754
inflight
inherits
ini
invert-kv
is-fullwidth-code-point
is-iojs
isarray
isexe
isomorphic-ws
js-sdsl
jsonfile
lcid
leven
listenercount
lodash
lodash.pad
lodash.padend
lodash.padstart
lru-cache
memory-stream
minimatch
minimist
minipass
minizlib
mkdirp
mqtt
mqtt-packet
ms
npmlog
number-allocator
number-is-nan
once
os-locale
path-is-absolute
process-nextick-args
pump
rc
readable-stream
reinterval
rfdc
rimraf
safe-buffer
semver
setimmediate
split2
splitargs
stream-shift
string-width
string_decoder
strip-ansi
strip-json-comments
tar
traverse
typedarray
universalify
unzipper
url-join
util-deprecate
which
window-size
wrap-ansi
wrappy
ws
xtend
y18n
yallist
yargs

This is blocking the AWS SDK for JavaScript (v3) from reducing the install size.

Describe the solution you'd like

Remove unnecessary dependencies from aws-crt

Describe alternatives you've considered

N/A

Additional context

  • We noticed this issue while measuring the install size of the AWS SDK for JavaScript (v3) in JS-3470
  • Internal ticket with AWS CRT: P67533319
@trivikr
Copy link
Member Author

trivikr commented Jul 7, 2022

The size of node_modules is 30M:

$ test-aws-crt> du -sh node_modules 
 30M	node_modules

@trivikr
Copy link
Member Author

trivikr commented Jul 12, 2022

It looks like the dependencies added under install script can be moved to devDependencies, as the script is only run in development.

Dependencies:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. p3 This is a minor priority issue
Projects
None yet
Development

No branches or pull requests

2 participants