Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extraction behavior seems a bit off #74

Closed
eagr opened this issue Sep 2, 2022 · 3 comments · Fixed by #158
Closed

Extraction behavior seems a bit off #74

eagr opened this issue Sep 2, 2022 · 3 comments · Fixed by #158
Labels
bug Something isn't working command:extract

Comments

@eagr
Copy link
Contributor

eagr commented Sep 2, 2022

From the HTTP/3 spec.

If the certificate is not acceptable with regard to the new origin
for any reason, the connection MUST NOT be reused and a new
connection SHOULD be established for the new origin.

There are two keywords of different requirement levels, and it results in a single entry of spec requirement.

[[spec]]
level = "MUST"
quote = '''
If the certificate is not acceptable with regard to the new origin
for any reason, the connection MUST NOT be reused and a new
connection SHOULD be established for the new origin.
'''

Each code of the format 0x1f * N + 0x21 for non-negative integer
values of N (that is, 0x21, 0x40, ..., through 0x3ffffffffffffffe)
MUST NOT be assigned by IANA and MUST NOT appear in the listing of
assigned values.

This one contains two keywords of the same requirement level, yet it results in two entries of spec requirements. A bit surprising.

[[spec]]
level = "MUST"
quote = '''
Each code of the format 0x1f * N + 0x21 for non-negative integer
values of N (that is, 0x21, 0x40, ..., through 0x3ffffffffffffffe)
MUST NOT be assigned by IANA and MUST NOT appear in the listing of
assigned values.
'''

[[spec]]
level = "MUST"
quote = '''
Each code of the format 0x1f * N + 0x21 for non-negative integer
values of N (that is, 0x21, 0x40, ..., through 0x3ffffffffffffffe)
MUST NOT be assigned by IANA and MUST NOT appear in the listing of
assigned values.
'''
@camshaft
Copy link
Member

camshaft commented Sep 2, 2022

For the first one, the extract logic isn't sophisticated enough to split on conjunctions. So, instead, if multiple requirements are specified in a single sentence then it takes the highest level.

For the second one that seems like a bug.

@eagr
Copy link
Contributor Author

eagr commented Sep 2, 2022

Yeah, the first one was kinda expected. And based on the assumption of which, the second just seemed off.

@camshaft
Copy link
Member

I opened #159 to track the compound issue separately. #158 should fix the extraction bug.

@camshaft camshaft mentioned this issue Jan 23, 2025
Merged
@camshaft camshaft added bug Something isn't working command:extract labels Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working command:extract
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: dedup extracted requirements awslabs/duvet
2 participants
@camshaft @eagr