From 7e5222ba9db25b0a1fcbd40453dbc68f70387cb3 Mon Sep 17 00:00:00 2001 From: blockchainguyy Date: Tue, 25 Jun 2024 20:09:56 +0530 Subject: [PATCH 01/16] feat: add check to incorporate strict signatures length validation --- contracts/governance/BaseWeightedMultisig.sol | 9 +++++++-- contracts/interfaces/IBaseWeightedMultisig.sol | 1 + 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/contracts/governance/BaseWeightedMultisig.sol b/contracts/governance/BaseWeightedMultisig.sol index 60768629..f4c30f05 100644 --- a/contracts/governance/BaseWeightedMultisig.sol +++ b/contracts/governance/BaseWeightedMultisig.sol @@ -216,8 +216,13 @@ abstract contract BaseWeightedMultisig is IBaseWeightedMultisig { // accumulating signatures weight totalWeight = totalWeight + signers[signerIndex].weight; - // weight needs to reach or surpass threshold - if (totalWeight >= weightedSigners.threshold) return; + // weight needs to reach threshold + if (totalWeight >= weightedSigners.threshold) { + // check if number of signatures exceed required amount of signatures + if (signaturesLength - 1 != i) revert InvalidSignaturesLength(signaturesLength, i + 1); + + return; + } // increasing signers index if match was found ++signerIndex; diff --git a/contracts/interfaces/IBaseWeightedMultisig.sol b/contracts/interfaces/IBaseWeightedMultisig.sol index f031998a..c0f6322b 100644 --- a/contracts/interfaces/IBaseWeightedMultisig.sol +++ b/contracts/interfaces/IBaseWeightedMultisig.sol @@ -9,6 +9,7 @@ interface IBaseWeightedMultisig { error LowSignaturesWeight(); error InvalidWeights(); error DuplicateSigners(bytes32 signersHash); + error InvalidSignaturesLength(uint256 provided, uint256 required); error InsufficientRotationDelay(uint256 minimumRotationDelay, uint256 lastRotationTimestamp, uint256 timeElapsed); event SignersRotated(uint256 indexed epoch, bytes32 indexed signersHash, bytes signers); From 9b4baf0aebddfc16a59d15ef4bd76d2a1fe4f03a Mon Sep 17 00:00:00 2001 From: blockchainguyy Date: Tue, 25 Jun 2024 20:10:11 +0530 Subject: [PATCH 02/16] test: add test for strict signatures length validation --- test/governance/BaseWeightedMultisig.js | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/test/governance/BaseWeightedMultisig.js b/test/governance/BaseWeightedMultisig.js index 099da842..ad2f70c3 100644 --- a/test/governance/BaseWeightedMultisig.js +++ b/test/governance/BaseWeightedMultisig.js @@ -374,14 +374,6 @@ describe('BaseWeightedMultisig', () => { await multisig.validateProofCall(dataHash, proof).then((tx) => tx.wait()); }); - it('validate the proof from the current signers with extra signatures', async () => { - // sign with all signers, i.e more than threshold - const proof = await getWeightedSignersProof(data, domainSeparator, weightedSigners, signers); - - const isCurrentSigners = await multisig.validateProof(dataHash, proof); - expect(isCurrentSigners).to.be.true; - }); - it('validate the proof with last threshold signers', async () => { const proof = await getWeightedSignersProof( data, @@ -481,6 +473,18 @@ describe('BaseWeightedMultisig', () => { 'LowSignaturesWeight', ); }); + + it('reject the proof if number of total signatures exceed required signatures', async () => { + // sign with all signers, i.e more than threshold + const proof = await getWeightedSignersProof(data, domainSeparator, weightedSigners, signers); + + await expectRevert( + async (gasOptions) => multisig.validateProof(dataHash, proof), + multisig, + 'InvalidSignaturesLength', + [proof.signatures.length, signers.slice(0, threshold)], + ); + }); }); }); From 5cc2b821faccac4d227c2f7b63678829071e621d Mon Sep 17 00:00:00 2001 From: blockchainguyy Date: Wed, 26 Jun 2024 16:58:32 +0530 Subject: [PATCH 03/16] refactor: update error name for exessive signature provided --- contracts/governance/BaseWeightedMultisig.sol | 4 ++-- contracts/interfaces/IBaseWeightedMultisig.sol | 2 +- test/governance/BaseWeightedMultisig.js | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/contracts/governance/BaseWeightedMultisig.sol b/contracts/governance/BaseWeightedMultisig.sol index f4c30f05..55881d2c 100644 --- a/contracts/governance/BaseWeightedMultisig.sol +++ b/contracts/governance/BaseWeightedMultisig.sol @@ -219,9 +219,9 @@ abstract contract BaseWeightedMultisig is IBaseWeightedMultisig { // weight needs to reach threshold if (totalWeight >= weightedSigners.threshold) { // check if number of signatures exceed required amount of signatures - if (signaturesLength - 1 != i) revert InvalidSignaturesLength(signaturesLength, i + 1); + if (signaturesLength - i == 1) return; - return; + revert ExcessiveSignaturesProvided(signaturesLength - i - 1); } // increasing signers index if match was found diff --git a/contracts/interfaces/IBaseWeightedMultisig.sol b/contracts/interfaces/IBaseWeightedMultisig.sol index c0f6322b..349d027f 100644 --- a/contracts/interfaces/IBaseWeightedMultisig.sol +++ b/contracts/interfaces/IBaseWeightedMultisig.sol @@ -9,7 +9,7 @@ interface IBaseWeightedMultisig { error LowSignaturesWeight(); error InvalidWeights(); error DuplicateSigners(bytes32 signersHash); - error InvalidSignaturesLength(uint256 provided, uint256 required); + error ExcessiveSignaturesProvided(uint256 difference); error InsufficientRotationDelay(uint256 minimumRotationDelay, uint256 lastRotationTimestamp, uint256 timeElapsed); event SignersRotated(uint256 indexed epoch, bytes32 indexed signersHash, bytes signers); diff --git a/test/governance/BaseWeightedMultisig.js b/test/governance/BaseWeightedMultisig.js index ad2f70c3..db37f25a 100644 --- a/test/governance/BaseWeightedMultisig.js +++ b/test/governance/BaseWeightedMultisig.js @@ -481,8 +481,8 @@ describe('BaseWeightedMultisig', () => { await expectRevert( async (gasOptions) => multisig.validateProof(dataHash, proof), multisig, - 'InvalidSignaturesLength', - [proof.signatures.length, signers.slice(0, threshold)], + 'ExcessiveSignaturesProvided', + [proof.signatures.length - signers.slice(0, threshold)], ); }); }); From e05cea55572f66e9c92c66772488d9d875a72d04 Mon Sep 17 00:00:00 2001 From: blockchainguyy Date: Wed, 26 Jun 2024 17:06:02 +0530 Subject: [PATCH 04/16] refactor: add comment stating operator is optional param --- contracts/gateway/AxelarAmplifierGateway.sol | 1 + 1 file changed, 1 insertion(+) diff --git a/contracts/gateway/AxelarAmplifierGateway.sol b/contracts/gateway/AxelarAmplifierGateway.sol index c66a62df..30fe69fc 100644 --- a/contracts/gateway/AxelarAmplifierGateway.sol +++ b/contracts/gateway/AxelarAmplifierGateway.sol @@ -53,6 +53,7 @@ contract AxelarAmplifierGateway is BaseAmplifierGateway, BaseWeightedMultisig, U function _setup(bytes calldata data) internal override { (address operator_, WeightedSigners[] memory signers) = abi.decode(data, (address, WeightedSigners[])); + // operator is an optional parameter, it can also be removed in the future to make ownership completely decentralized if (operator_ != address(0)) { _transferOperatorship(operator_); } From 1cc81ed61e8ddfc2cc9bb81020afe3dfdb732acc Mon Sep 17 00:00:00 2001 From: blockchainguyy Date: Wed, 26 Jun 2024 18:23:58 +0530 Subject: [PATCH 05/16] refactor: resolve PR comments --- contracts/governance/BaseWeightedMultisig.sol | 5 +++-- contracts/interfaces/IBaseWeightedMultisig.sol | 2 +- test/governance/BaseWeightedMultisig.js | 6 +++--- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/contracts/governance/BaseWeightedMultisig.sol b/contracts/governance/BaseWeightedMultisig.sol index 55881d2c..bc426cea 100644 --- a/contracts/governance/BaseWeightedMultisig.sol +++ b/contracts/governance/BaseWeightedMultisig.sol @@ -107,6 +107,7 @@ abstract contract BaseWeightedMultisig is IBaseWeightedMultisig { * @param proof The multisig proof data * @return isLatestSigners True if the proof is from the latest signer set * @dev The proof data should have signers, weights, threshold and signatures encoded + * The proof is only valid if signers weight crosses threshold and there are no redundant signatures * The signers and signatures should be sorted by signer address in ascending order * Example: abi.encode([0x11..., 0x22..., 0x33...], [1, 1, 1], 2, [signature1, signature3]) */ @@ -218,10 +219,10 @@ abstract contract BaseWeightedMultisig is IBaseWeightedMultisig { // weight needs to reach threshold if (totalWeight >= weightedSigners.threshold) { - // check if number of signatures exceed required amount of signatures + // check if there are redundant signatures if (signaturesLength - i == 1) return; - revert ExcessiveSignaturesProvided(signaturesLength - i - 1); + revert RedundantSignaturesProvided(i + 1, signaturesLength); } // increasing signers index if match was found diff --git a/contracts/interfaces/IBaseWeightedMultisig.sol b/contracts/interfaces/IBaseWeightedMultisig.sol index 349d027f..3430e189 100644 --- a/contracts/interfaces/IBaseWeightedMultisig.sol +++ b/contracts/interfaces/IBaseWeightedMultisig.sol @@ -9,7 +9,7 @@ interface IBaseWeightedMultisig { error LowSignaturesWeight(); error InvalidWeights(); error DuplicateSigners(bytes32 signersHash); - error ExcessiveSignaturesProvided(uint256 difference); + error RedundantSignaturesProvided(uint256 required, uint256 provided); error InsufficientRotationDelay(uint256 minimumRotationDelay, uint256 lastRotationTimestamp, uint256 timeElapsed); event SignersRotated(uint256 indexed epoch, bytes32 indexed signersHash, bytes signers); diff --git a/test/governance/BaseWeightedMultisig.js b/test/governance/BaseWeightedMultisig.js index db37f25a..f26fa8d8 100644 --- a/test/governance/BaseWeightedMultisig.js +++ b/test/governance/BaseWeightedMultisig.js @@ -474,15 +474,15 @@ describe('BaseWeightedMultisig', () => { ); }); - it('reject the proof if number of total signatures exceed required signatures', async () => { + it('reject the proof if there are redundant signatures', async () => { // sign with all signers, i.e more than threshold const proof = await getWeightedSignersProof(data, domainSeparator, weightedSigners, signers); await expectRevert( async (gasOptions) => multisig.validateProof(dataHash, proof), multisig, - 'ExcessiveSignaturesProvided', - [proof.signatures.length - signers.slice(0, threshold)], + 'RedundantSignaturesProvided', + [signers.slice(0, threshold), proof.signatures.length], ); }); }); From e7eae0d1742fb95134194fdd71ce53b61b00e1f3 Mon Sep 17 00:00:00 2001 From: Blockchain Guy Date: Thu, 27 Jun 2024 13:20:04 +0530 Subject: [PATCH 06/16] refactor: update comment for redundant signatures check Co-authored-by: Milap Sheth --- contracts/governance/BaseWeightedMultisig.sol | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contracts/governance/BaseWeightedMultisig.sol b/contracts/governance/BaseWeightedMultisig.sol index bc426cea..5fd55dd6 100644 --- a/contracts/governance/BaseWeightedMultisig.sol +++ b/contracts/governance/BaseWeightedMultisig.sol @@ -219,7 +219,7 @@ abstract contract BaseWeightedMultisig is IBaseWeightedMultisig { // weight needs to reach threshold if (totalWeight >= weightedSigners.threshold) { - // check if there are redundant signatures + // validate the proof if there are no redundant signatures if (signaturesLength - i == 1) return; revert RedundantSignaturesProvided(i + 1, signaturesLength); From fbd997e8012f4d7a58a4df3e7d94cc590ecefb7f Mon Sep 17 00:00:00 2001 From: Blockchain Guy Date: Thu, 27 Jun 2024 13:21:25 +0530 Subject: [PATCH 07/16] refactor: check for redundant signatures Co-authored-by: Milap Sheth --- contracts/governance/BaseWeightedMultisig.sol | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contracts/governance/BaseWeightedMultisig.sol b/contracts/governance/BaseWeightedMultisig.sol index 5fd55dd6..0cb34cd8 100644 --- a/contracts/governance/BaseWeightedMultisig.sol +++ b/contracts/governance/BaseWeightedMultisig.sol @@ -220,7 +220,7 @@ abstract contract BaseWeightedMultisig is IBaseWeightedMultisig { // weight needs to reach threshold if (totalWeight >= weightedSigners.threshold) { // validate the proof if there are no redundant signatures - if (signaturesLength - i == 1) return; + if (i + 1 == signaturesLength) return; revert RedundantSignaturesProvided(i + 1, signaturesLength); } From 30bcb69202bbbf07c71b4f15c20734cde7243cb5 Mon Sep 17 00:00:00 2001 From: Blockchain Guy Date: Thu, 27 Jun 2024 13:22:02 +0530 Subject: [PATCH 08/16] refactor: comment for proof validation condition Co-authored-by: Milap Sheth --- contracts/governance/BaseWeightedMultisig.sol | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contracts/governance/BaseWeightedMultisig.sol b/contracts/governance/BaseWeightedMultisig.sol index 0cb34cd8..bb8a917e 100644 --- a/contracts/governance/BaseWeightedMultisig.sol +++ b/contracts/governance/BaseWeightedMultisig.sol @@ -107,7 +107,7 @@ abstract contract BaseWeightedMultisig is IBaseWeightedMultisig { * @param proof The multisig proof data * @return isLatestSigners True if the proof is from the latest signer set * @dev The proof data should have signers, weights, threshold and signatures encoded - * The proof is only valid if signers weight crosses threshold and there are no redundant signatures + * The proof is only valid if the signers weight crosses the threshold and there are no redundant signatures * The signers and signatures should be sorted by signer address in ascending order * Example: abi.encode([0x11..., 0x22..., 0x33...], [1, 1, 1], 2, [signature1, signature3]) */ From c77f292586f415c07214e019e708802e3de8c528 Mon Sep 17 00:00:00 2001 From: Blockchain Guy Date: Thu, 27 Jun 2024 13:23:46 +0530 Subject: [PATCH 09/16] refactor: update comment for optional parameter operator Co-authored-by: Milap Sheth --- contracts/gateway/AxelarAmplifierGateway.sol | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/contracts/gateway/AxelarAmplifierGateway.sol b/contracts/gateway/AxelarAmplifierGateway.sol index 30fe69fc..54606118 100644 --- a/contracts/gateway/AxelarAmplifierGateway.sol +++ b/contracts/gateway/AxelarAmplifierGateway.sol @@ -53,7 +53,8 @@ contract AxelarAmplifierGateway is BaseAmplifierGateway, BaseWeightedMultisig, U function _setup(bytes calldata data) internal override { (address operator_, WeightedSigners[] memory signers) = abi.decode(data, (address, WeightedSigners[])); - // operator is an optional parameter, it can also be removed in the future to make ownership completely decentralized + // operator is an optional parameter. The gateway owner can set it later if needed. + // This also simplifies setup for upgrades so if the current operator doesn't need to be changed, then it can be skipped, instead of having to specify the current operator again. if (operator_ != address(0)) { _transferOperatorship(operator_); } From 508c811dbee1bfa4800a63a87024fb95d67371e3 Mon Sep 17 00:00:00 2001 From: blockchainguyy Date: Thu, 27 Jun 2024 20:00:14 +0530 Subject: [PATCH 10/16] test: add test to deploy gateway without operator --- test/gateway/AxelarAmplifierGateway.js | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/test/gateway/AxelarAmplifierGateway.js b/test/gateway/AxelarAmplifierGateway.js index e0cfe443..273603fd 100644 --- a/test/gateway/AxelarAmplifierGateway.js +++ b/test/gateway/AxelarAmplifierGateway.js @@ -212,6 +212,32 @@ describe('AxelarAmplifierGateway', () => { expect(await gateway.operator()).to.equal(operator.address); }); + it('should allow deploying gateway with address 0 as the operator', async () => { + const signers = defaultAbiCoder.encode( + ['address', `${WEIGHTED_SIGNERS_TYPE}[]`], + [AddressZero, [weightedSigners]], + ); + + implementation = await gatewayFactory.deploy( + previousSignersRetention, + domainSeparator, + minimumRotationDelay, + ); + await implementation.deployTransaction.wait(network.config.confirmations); + + const proxy = await gatewayProxyFactory.deploy( + implementation.address, + owner.address, + signers, + getGasOptions(), + ); + await proxy.deployTransaction.wait(network.config.confirmations); + + gateway = gatewayFactory.attach(proxy.address); + + expect(await gateway.operator()).to.equal(AddressZero); + }); + it('reject transferring ownership by non-owner', async () => { await expectRevert( (gasOptions) => gateway.connect(operator).transferOwnership(operator.address, gasOptions), From e5816fa59ffd1d5a5c63dea12ff3a89354bef1e3 Mon Sep 17 00:00:00 2001 From: blockchainguyy Date: Thu, 27 Jun 2024 20:19:32 +0530 Subject: [PATCH 11/16] fix: failing operator test --- test/gateway/AxelarAmplifierGateway.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/gateway/AxelarAmplifierGateway.js b/test/gateway/AxelarAmplifierGateway.js index 273603fd..5b202380 100644 --- a/test/gateway/AxelarAmplifierGateway.js +++ b/test/gateway/AxelarAmplifierGateway.js @@ -218,7 +218,7 @@ describe('AxelarAmplifierGateway', () => { [AddressZero, [weightedSigners]], ); - implementation = await gatewayFactory.deploy( + const implementation = await gatewayFactory.deploy( previousSignersRetention, domainSeparator, minimumRotationDelay, @@ -233,7 +233,7 @@ describe('AxelarAmplifierGateway', () => { ); await proxy.deployTransaction.wait(network.config.confirmations); - gateway = gatewayFactory.attach(proxy.address); + const gateway = gatewayFactory.attach(proxy.address); expect(await gateway.operator()).to.equal(AddressZero); }); From 2fab37ad6061f5551307f96e96aa5643f44d8d79 Mon Sep 17 00:00:00 2001 From: Milap Sheth Date: Sun, 30 Jun 2024 18:55:48 -0400 Subject: [PATCH 12/16] Update contracts/gateway/AxelarAmplifierGateway.sol --- contracts/gateway/AxelarAmplifierGateway.sol | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contracts/gateway/AxelarAmplifierGateway.sol b/contracts/gateway/AxelarAmplifierGateway.sol index 54606118..f42a000e 100644 --- a/contracts/gateway/AxelarAmplifierGateway.sol +++ b/contracts/gateway/AxelarAmplifierGateway.sol @@ -53,7 +53,7 @@ contract AxelarAmplifierGateway is BaseAmplifierGateway, BaseWeightedMultisig, U function _setup(bytes calldata data) internal override { (address operator_, WeightedSigners[] memory signers) = abi.decode(data, (address, WeightedSigners[])); - // operator is an optional parameter. The gateway owner can set it later if needed. + // operator is an optional parameter. The gateway owner can set it later via `transferOperatorship` if needed. // This also simplifies setup for upgrades so if the current operator doesn't need to be changed, then it can be skipped, instead of having to specify the current operator again. if (operator_ != address(0)) { _transferOperatorship(operator_); From 44f8044de6ba14f0e72fd026593b4830c938968d Mon Sep 17 00:00:00 2001 From: blockchainguyy Date: Mon, 1 Jul 2024 13:39:06 +0530 Subject: [PATCH 13/16] refactor: remove address check from transfer operatorship --- contracts/gateway/AxelarAmplifierGateway.sol | 2 -- 1 file changed, 2 deletions(-) diff --git a/contracts/gateway/AxelarAmplifierGateway.sol b/contracts/gateway/AxelarAmplifierGateway.sol index f42a000e..eaaad54d 100644 --- a/contracts/gateway/AxelarAmplifierGateway.sol +++ b/contracts/gateway/AxelarAmplifierGateway.sol @@ -129,8 +129,6 @@ contract AxelarAmplifierGateway is BaseAmplifierGateway, BaseWeightedMultisig, U * @param newOperator The address of the new operator. */ function transferOperatorship(address newOperator) external onlyOperatorOrOwner { - if (newOperator == address(0)) revert InvalidOperator(); - _transferOperatorship(newOperator); } From 29ed02a013a9b80d0ab676bb79439664f20c2cc8 Mon Sep 17 00:00:00 2001 From: blockchainguyy Date: Mon, 1 Jul 2024 13:39:49 +0530 Subject: [PATCH 14/16] test: add test to transfer operatorship to address zero --- test/gateway/AxelarAmplifierGateway.js | 34 +++----------------------- 1 file changed, 4 insertions(+), 30 deletions(-) diff --git a/test/gateway/AxelarAmplifierGateway.js b/test/gateway/AxelarAmplifierGateway.js index 5b202380..9ed4d57b 100644 --- a/test/gateway/AxelarAmplifierGateway.js +++ b/test/gateway/AxelarAmplifierGateway.js @@ -212,28 +212,10 @@ describe('AxelarAmplifierGateway', () => { expect(await gateway.operator()).to.equal(operator.address); }); - it('should allow deploying gateway with address 0 as the operator', async () => { - const signers = defaultAbiCoder.encode( - ['address', `${WEIGHTED_SIGNERS_TYPE}[]`], - [AddressZero, [weightedSigners]], - ); - - const implementation = await gatewayFactory.deploy( - previousSignersRetention, - domainSeparator, - minimumRotationDelay, - ); - await implementation.deployTransaction.wait(network.config.confirmations); - - const proxy = await gatewayProxyFactory.deploy( - implementation.address, - owner.address, - signers, - getGasOptions(), - ); - await proxy.deployTransaction.wait(network.config.confirmations); - - const gateway = gatewayFactory.attach(proxy.address); + it('should allow transferring operatorship to the zero address', async () => { + await expect(gateway.connect(owner).transferOperatorship(AddressZero)) + .to.emit(gateway, 'OperatorshipTransferred') + .withArgs(AddressZero); expect(await gateway.operator()).to.equal(AddressZero); }); @@ -254,14 +236,6 @@ describe('AxelarAmplifierGateway', () => { [user.address], ); }); - - it('reject transferring operatorship to the zero address', async () => { - await expectRevert( - (gasOptions) => gateway.connect(operator).transferOperatorship(AddressZero, gasOptions), - gateway, - 'InvalidOperator', - ); - }); }); describe('validate message', async () => { From b5ff4cf4299e11cc888d3262ab8ded16e0a4b773 Mon Sep 17 00:00:00 2001 From: blockchainguyy Date: Mon, 1 Jul 2024 16:02:45 +0530 Subject: [PATCH 15/16] refactor: add comment for transferring operator role to address 0 --- contracts/gateway/AxelarAmplifierGateway.sol | 1 + 1 file changed, 1 insertion(+) diff --git a/contracts/gateway/AxelarAmplifierGateway.sol b/contracts/gateway/AxelarAmplifierGateway.sol index eaaad54d..050f99c3 100644 --- a/contracts/gateway/AxelarAmplifierGateway.sol +++ b/contracts/gateway/AxelarAmplifierGateway.sol @@ -126,6 +126,7 @@ contract AxelarAmplifierGateway is BaseAmplifierGateway, BaseWeightedMultisig, U /** * @notice Transfer the operatorship to a new address. + * @dev The owner or current operator can set the operator to address 0. * @param newOperator The address of the new operator. */ function transferOperatorship(address newOperator) external onlyOperatorOrOwner { From 082794d780b7e448a31f618ae8b497cad43022af Mon Sep 17 00:00:00 2001 From: blockchainguyy Date: Tue, 2 Jul 2024 13:04:24 +0530 Subject: [PATCH 16/16] refactor: remove unused error --- contracts/interfaces/IAxelarAmplifierGateway.sol | 1 - 1 file changed, 1 deletion(-) diff --git a/contracts/interfaces/IAxelarAmplifierGateway.sol b/contracts/interfaces/IAxelarAmplifierGateway.sol index a24af28a..34143e64 100644 --- a/contracts/interfaces/IAxelarAmplifierGateway.sol +++ b/contracts/interfaces/IAxelarAmplifierGateway.sol @@ -16,7 +16,6 @@ import { Message } from '../types/AmplifierGatewayTypes.sol'; interface IAxelarAmplifierGateway is IBaseAmplifierGateway, IBaseWeightedMultisig, IUpgradable { error NotLatestSigners(); error InvalidSender(address sender); - error InvalidOperator(); event OperatorshipTransferred(address newOperator);