Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add derive rkyv Serialize/Deserialize #20

Open
jonathanpwang opened this issue Dec 18, 2023 · 0 comments
Open

Add derive rkyv Serialize/Deserialize #20

jonathanpwang opened this issue Dec 18, 2023 · 0 comments

Comments

@jonathanpwang
Copy link

As described in #19, currently the Serialize, Deserialize implementations for bn256::{Fr, G1Affine} are using the human-readable (aka to_repr() implementations) format. One should remember that this means you should NOT use Serialize, Deserialize implementations for anything where performance is critical (such as serializing/deserializing proving keys).

Currently we use bincode with the derived Serialize, Deserialize on Snark, but since snark proofs are pretty small it should be inconsequential.

We should add custom derive for rkyv::{Serialize,Deserialize} and possibly also bincode::{Serialize,Deserialize} so we can benchmark/compare different serde strategies for proving keys: axiom-crypto/halo2#7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant