Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add xtask to aya-template #183

Closed
endepointe opened this issue Nov 25, 2024 · 3 comments
Closed

add xtask to aya-template #183

endepointe opened this issue Nov 25, 2024 · 3 comments

Comments

@endepointe
Copy link

endepointe commented Nov 25, 2024

Hey rustaceans. I went through the setup, using the aya-template and I am curious why the xtask is not part of the template? Also, why is cargo-xtask not referenced in the tutorials https://aya-rs.dev/book/start/ ? There are a few crates that reference xtask* so it was rather confusing at first to know what xtask package was being referred to in the xdp-hello example.

This issue is a nice-to-have or documentation label.

Thanks for the future feedback!

@endepointe
Copy link
Author

User-defined aliases will become errors in the future if using cargo-xtask so how will aya minimize this issue?

cargo xtask run -- -h                                                                                                                                                                            
warning: user-defined alias `xtask` is shadowing an external subcommand found at: `/home/ende/.cargo/bin/cargo-xtask`                                                                                                                         
This was previously accepted but is being phased out; it will become a hard error in a future release.                                                                                                                                        
For more information, see issue #10049 <https://github.com/rust-lang/cargo/issues/10049>.     

@tamird
Copy link
Member

tamird commented Nov 26, 2024

We are moving away from xtask. See aya-rs/aya-template#124 and aya-rs/aya-template#132.

The book examples still refer to xtask because we haven't updated those programs, which is what we should actually do.

@tamird
Copy link
Member

tamird commented Nov 26, 2024

Closing as duplicate of #176.

@tamird tamird closed this as completed Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants