Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Remove validation of external defined code sets #65

Open
azoner opened this issue Jan 12, 2020 · 4 comments
Open

Feature Request: Remove validation of external defined code sets #65

azoner opened this issue Jan 12, 2020 · 4 comments

Comments

@azoner
Copy link
Owner

azoner commented Jan 12, 2020

Code set values for certain X12 elements were included in the original implementation guide, and also listed an external defining organization. These code sets can and do change out of tempo with the X12 major versions and addendum.

Maintenance of these code sets has been infrequent; which can result in validation issue.

I propose removing the validation of any code set that depends on external definers, where the code is likely to change between major X12 versions. These would include:

adjustment_reason
claim_status
claim_status_cat
country
currency
entity_id
pos
prov_taxonomy
remark_code

These code set identifiers and associate code values are defined in the file codes.xml

Let me know what you think.

@ddw360
Copy link

ddw360 commented May 8, 2020

it would be better to allow validation as an optional switch for any x12 source file validation or transformation operation. In other words without the switch, no validation of the external defined code sets would happen. With switch on - validation of external defined code sets could occur. With validation on - the code sets should be maintained in a separate file (outside of code) - that can be maintained outside of code and modified as needed by any user of the library as needed.

@azoner
Copy link
Owner Author

azoner commented May 8, 2020

I like that idea in general. The external codesets are already in an external file - codes.xml. Users are free to make modifications to their local copy.

state and country might be stable enough to default to always on. The simple approach is your idea of defaulting to no external validation.

@ddw360
Copy link

ddw360 commented May 8, 2020

so default - no validation. and if switched on via arg/param - caveat re: using/reviewing codes.xml. as a happy user of pyx12 - I would be good with this personally.

@azoner
Copy link
Owner Author

azoner commented May 8, 2020

I will implement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants