Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark overloaded Click and DoubleClick as obsolete #618

Closed
linkdotnet opened this issue Jan 31, 2022 · 3 comments
Closed

Mark overloaded Click and DoubleClick as obsolete #618

linkdotnet opened this issue Jan 31, 2022 · 3 comments
Milestone

Comments

@linkdotnet
Copy link
Collaborator

linkdotnet commented Jan 31, 2022

This is a pre-cursor for #617

If we want to implement #617 we should give the user a "notice period". Therefore the suggestion would be to mark all overloads of Click and DoubleClick which are not using directly the MouseEventArgs as obsolete.

@linkdotnet
Copy link
Collaborator Author

@egil I made two "issues" out of the original discussion here. We could merge them but from a temporal point of view one is before the other.

@egil
Copy link
Member

egil commented Jan 31, 2022

I am inclined to NOT add the Obsolete attribute and simply remove the methods for v2. Most wont notice it during upgrade because they will simply be able to recompile and it will work because they do not use any the parameters in the methods. But ill leave this issue here so we can make a final decision later.

@egil egil added this to the 2.0.0 milestone Jan 31, 2022
@linkdotnet
Copy link
Collaborator Author

Okay sorry that is on my :) I misunderstood this a bit.
Of course it would only make sense to mark methods a priori v2 so that the users have a chance of noticing and reacting.

But to be fair the change is very very small without any side effects. I guess one sentence in the „How to migrate“ should cover that issue.

Therefore let’s close that issue and I’ll the requirement of adding some documentation to the other one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants