From e99764a7541be76291f837d24653075489f9a17b Mon Sep 17 00:00:00 2001 From: RafilxTenfen Date: Mon, 13 Jan 2025 08:53:24 -0300 Subject: [PATCH] chore: add test that verifies if all the delegations pointers wasn't pointing to the last one --- covenant/covenant_test.go | 33 ++++++++++++++++++++++++--------- 1 file changed, 24 insertions(+), 9 deletions(-) diff --git a/covenant/covenant_test.go b/covenant/covenant_test.go index 30491da..bbd1af5 100644 --- a/covenant/covenant_test.go +++ b/covenant/covenant_test.go @@ -314,16 +314,31 @@ func TestIsKeyInCommittee(t *testing.T) { dels = covenant.SanitizeDelegations(covKeyPair.PublicKey, paramsGet, []*types.Delegation{delWithCovenant}) require.Len(t, dels, 1) - lastUnsanitizedDels := []*types.Delegation{delWithCovenant, delWithCovenant, delNoCovenant} + amtSatFirst := btcutil.Amount(100) + amtSatSecond := btcutil.Amount(150) + amtSatThird := btcutil.Amount(200) + lastUnsanitizedDels := []*types.Delegation{ + &types.Delegation{ + ParamsVersion: pVersionWithCovenant, + TotalSat: amtSatFirst, + }, + delNoCovenant, + &types.Delegation{ + ParamsVersion: pVersionWithCovenant, + TotalSat: amtSatSecond, + }, + delNoCovenant, + &types.Delegation{ + ParamsVersion: pVersionWithCovenant, + TotalSat: amtSatThird, + }, + } + sanitizedDels := covenant.SanitizeDelegations(covKeyPair.PublicKey, paramsGet, lastUnsanitizedDels) - require.Len(t, sanitizedDels, 2) - - // change something in the lastUnsanitezedDels pointer to see if it modifies in the delegations - // it shouldn't modify the sanitized - endHeightSet := uint32(1000) - delWithCovenant.EndHeight = endHeightSet - require.Equal(t, lastUnsanitizedDels[0].EndHeight, endHeightSet) - require.Equal(t, sanitizedDels[0].EndHeight, endHeightSet) + require.Len(t, sanitizedDels, 3) + require.Equal(t, amtSatFirst, sanitizedDels[0].TotalSat) + require.Equal(t, amtSatSecond, sanitizedDels[1].TotalSat) + require.Equal(t, amtSatThird, sanitizedDels[2].TotalSat) } type MockParamGetter struct {