Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve fpd start #289

Closed
gitferry opened this issue Jan 16, 2025 · 1 comment · Fixed by #294
Closed

Improve fpd start #289

gitferry opened this issue Jan 16, 2025 · 1 comment · Fixed by #294
Assignees
@gitferry
Labels
phase-2-readiness

Comments

@gitferry
Copy link
Member

gitferry commented Jan 16, 2025 •
edited
Loading

Current fpd start will not initiate the fp instance, which is confusing. To improve,

  1. fpd start to start the fp if there's a registered fp record in db
  2. ideally to have only one fp maintained in fpd, new registered fp can overwrite the old one
@gitferry gitferry self-assigned this Jan 16, 2025
@gitferry
Copy link
Member Author

  1. If --eots-pk is specified, start the specified fp instance. Otherwise,
  2. if no fp records found from db, start the daemon and show logs asking for registration
  3. if there's one fp record found from db, start the daemon with the fp
  4. if there are multiple fp record found from db, fail the cmd execution asking for set of --eots-pk

Further improvement can be made:

  1. ensure at most one fp record can exist. New one will overwrite the existing one with a prompt asking for confirmation (db should have backup).
  2. fp start right away after `fpd create-finality-provider

@gitferry gitferry mentioned this issue Jan 22, 2025
Merged
gitferry added a commit that referenced this issue Jan 27, 2025
@gitferry
chore: Improve fpd start (#294)
36fe94d 
Closes #289. With this pr, the `fpd start` flow becomes the follows:

- If --eots-pk is specified, start the specified fp instance. Otherwise,
- if no fp records found from db, start the daemon and show logs asking
for registration
- if there's one fp record found from db, start the daemon with the fp
- if there are multiple fp record found from db, fail the cmd execution
asking for set of --eots-pk
gitferry added a commit that referenced this issue Jan 27, 2025
@gitferry
chore: Improve fpd start (#294)
3e41aef 
Closes #289. With this pr, the `fpd start` flow becomes the follows:

- If --eots-pk is specified, start the specified fp instance. Otherwise,
- if no fp records found from db, start the daemon and show logs asking
for registration
- if there's one fp record found from db, start the daemon with the fp
- if there are multiple fp record found from db, fail the cmd execution
asking for set of --eots-pk
gitferry added a commit that referenced this issue Jan 27, 2025
@gitferry
chore: Improve fpd start (#294)
19d8db6 
Closes #289. With this pr, the `fpd start` flow becomes the follows:

- If --eots-pk is specified, start the specified fp instance. Otherwise,
- if no fp records found from db, start the daemon and show logs asking
for registration
- if there's one fp record found from db, start the daemon with the fp
- if there are multiple fp record found from db, fail the cmd execution
asking for set of --eots-pk
gitferry added a commit that referenced this issue Jan 27, 2025
@gitferry
chore: Improve fpd start (#294)
a00d279 
Closes #289. With this pr, the `fpd start` flow becomes the follows:

- If --eots-pk is specified, start the specified fp instance. Otherwise,
- if no fp records found from db, start the daemon and show logs asking
for registration
- if there's one fp record found from db, start the daemon with the fp
- if there are multiple fp record found from db, fail the cmd execution
asking for set of --eots-pk
@gitferry gitferry mentioned this issue Jan 27, 2025
Merged
gitferry added a commit that referenced this issue Jan 27, 2025
@gitferry
chore: Improve fpd start (#294)
1b41464 
Closes #289. With this pr, the `fpd start` flow becomes the follows:

- If --eots-pk is specified, start the specified fp instance. Otherwise,
- if no fp records found from db, start the daemon and show logs asking
for registration
- if there's one fp record found from db, start the daemon with the fp
- if there are multiple fp record found from db, fail the cmd execution
asking for set of --eots-pk
gitferry added a commit that referenced this issue Jan 27, 2025
@gitferry
[backport] chore: Improve fpd start (#294) (#305)
6460fdc 
Closes #289. With this pr, the `fpd start` flow becomes the follows:

- If --eots-pk is specified, start the specified fp instance. Otherwise,
- if no fp records found from db, start the daemon and show logs asking
for registration
- if there's one fp record found from db, start the daemon with the fp
- if there are multiple fp record found from db, fail the cmd execution
asking for set of --eots-pk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gitferry gitferry

Labels
phase-2-readiness
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Improve fpd start babylonlabs-io/finality-provider
1 participant
@gitferry