Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support to v2 schema #9

Closed
wants to merge 1 commit into from
Closed

Conversation

jeremy-babylonlabs
Copy link
Contributor

@jeremy-babylonlabs jeremy-babylonlabs commented Nov 17, 2024

closes #8

StakingTimeLock uint64 `json:"staking_timelock"`
StakingOutputIndex uint64 `json:"staking_output_index"`
StakingTxHex string `json:"staking_tx_hex"`
IsOverflow bool `json:"is_overflow"`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeremy-babylonlabs @gusin13 i think we need to review the msg events needed for phase-2.
For example, IsOverflow, StakingStartTimestamp, stakingTimeLock, stakingOutputIndex, and stakingTxHex don’t seem to be necessary.

If I’m not mistaken, we only need the staking transaction hash and its new state. Theoretically, this means we could significantly simplify the current messaging system.

We should align the msg with state changes in the indexer and only emit the fields that needed for performing the stats calculation

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm right, needs investigation.
let me check, @jeremy-babylonlabs this pr is not urgent correct as you already have local copy of schema in api-service?

is it ok if we close this pr, will open a new one later once i have clarity on schema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

schema v2 support
3 participants