Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Border separator is now on footer links. #41

Open
sikofitt opened this issue Feb 3, 2025 · 3 comments
Open

Border separator is now on footer links. #41

sikofitt opened this issue Feb 3, 2025 · 3 comments
Assignees
Labels
type - bug report Something isn't working

Comments

@sikofitt
Copy link
Collaborator

sikofitt commented Feb 3, 2025

There are borders on links in the global footer now. I believe this is a side affect of #33.

We should target the navigation menus explicitly, or add a selector to not target the footer links for this change.

Image

@sikofitt sikofitt added the type - bug report Something isn't working label Feb 3, 2025
@sikofitt sikofitt self-assigned this Feb 3, 2025
@irinaz
Copy link
Collaborator

irinaz commented Feb 3, 2025

@sikofitt , can you do a build on your local?

@sikofitt
Copy link
Collaborator Author

sikofitt commented Feb 3, 2025

@irinaz I will do this in a little bit.

@sikofitt
Copy link
Collaborator Author

sikofitt commented Feb 3, 2025

I'm getting the same thing on local.

Image

It is setting the border color to black in colors.css at line 132
And it is setting the border bottom width and border bottom to 1px in main.compiled.css.

@media (min-width: 768px) {
    .menu li:first-child, 
    .menu li.leaf:first-child, 
    .menu li.collapsed:first-child, 
    .menu li.expanded:first-child, 
    .menu-tree li:first-child, 
    .menu-tree li.leaf:first-child, 
    .menu-tree li.collapsed:first-child, 
    .menu-tree li.expanded:first-child {
        border-top-width: 1px;
    }
}
.menu li, 
.menu li.leaf, 
.menu li.collapsed, 
.menu li.expanded, 
.menu-tree li, 
.menu-tree li.leaf, 
.menu-tree li.collapsed, 
.menu-tree li.expanded {
   border-color: #000000;
}
.menu li, 
.menu li.leaf, 
.menu li.collapsed, 
.menu li.expanded, 
.menu-tree li, 
.menu-tree li.leaf, 
.menu-tree li.collapsed, 
.menu-tree li.expanded {
    float: none;
    list-style-type: none;
    list-style-image: none;
    padding: 0;
    border-bottom-width: 1px;
}

Un-clicking these rules fixed it. I'm not sure where in the scss these are though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type - bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants