-
-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Total tests time increased after updating from v20 to v21 #1256
Comments
Hey @KarineBrandelli. Did you by any chance update any other dependencies simultaneously, like your Cypress version? If so, can you revert said update, update only If it does, try each version between 20.1.2 and 21.0.2, to pinpoint exactly which version that introduces it. Furthermore, since I'm not seeing this myself, you will probably have to provide a reproducible example that illustrates the behavior. Lastly, why did you not do any of this before opening up an issue? |
I experienced the same issue. After upgrading from v20.1.2 to 21.0.2, it takes much longer on “Running: test.feature (1 of 1)”. As I figured out, it has to do with the number of defined steps. Having a simple project with a single feature and step definition, as defined below, works fine. Test execution takes a few seconds. Here is a sample of a simple feature:
This is the step definition for the feature:
As I mentioned before, this configuration works fine. However, if we add more steps in the step definition, the test execution time increases accordingly. For example, if we implement the following modification in the step definitions, the same execution takes half a minute, and it takes that extra time for each Feature:
I’ve tried the same code with v20.1.2 and it works fine. When I switch back to 21.0.2, the issue arises again. |
@mestevezcl, I'm not seeing the same behavior using your code snippets. Can you share a complete example? |
I have a sandbox, but I don't think is going to be very helpful. Downgrade the version on the package.json, run yarn then run yarn cy:run. |
There was a lot of internal refactoring made during v21.0.0.
I did help and I can now reproduce the behavior. A complete (ie. runnable) example contains a tremendous amount of information. It shows me what loader you're using and that you're writing component tests, neither which is apparent from your original post. This is exactly why I ask everyone to provide this up front and without me having to ask for it anymore than I already have (this is specifically explained in the issue template and the contributing guidelines). I'm not sure if I can get to this now, but I'll have a fix ready shortly-ish. |
@badeball As I said, I thought it was a machine setting, thus the runnable exemple not being very useful. Forgive me for that. I appreciate the time you took to look into this. Any updates let me know. |
This has been fixed with v21.0.3. |
With v21.0.3 it works fast again on my repo! Many thanks for the quick fix :) |
Current behavior
My tests were running way faster at the 20.1.2 version. After updating to the 21.0.2 version, the waiting time increased significantly.
At 20.1.2 version:
372.15 seconds
At 21.0.2 version:
3521.46 seconds
Which is odd, cause the tests separately have the time quite similar, but I was marking here on the clock, and it took all the time at the final.
Also, after updating, this warning is shown at the terminal:
Warning: terminator_CreateInstance: Failed to CreateInstance in ICD 2. Skipping ICD.
Desired behavior
Not affect the test time.
Versions
Checklist
[email protected]
(package name has changed and it is no longer the most recent version, see #689).The text was updated successfully, but these errors were encountered: