-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Drupal integration #3
Comments
Dear EelcoPeacs, |
Hi Bahriddin, |
Ok, sure I am happy to work together! |
Hi, @EelcoPeacs. Any news? |
Hi bahriddin, |
Thank you, @EelcoPeacs. Currently, I am working with the project where I used this plugin. So I will update my knowledge about CKEditor and hope to add some new features. |
Hi Bahriddin,
Great work. After looking into the potential video plugins for the CKEditor, I found yours most fitting to the functionality I require for a Drupal installation.
Unfortunately integrating two systems isn't always straitforward and I ran into some problems. After writing a simple Drupal module to integrate the html5video plugin and enabling it through the Drupal inteface, the button didn't show up on the CKEditor toolbar. I found out that the widgets "button:" property isn't correctly supported/handled.
Attached is a patch for the adjusted code which does bring the button to the toolbar in Drupal and doesn't break the functionality in a CKEditor setting. Part of it is that I renamed the edit dialog to include the word 'Dialog'. This isn't required, but it took me some time to get the difference between html5video and html5video. If you agree, I can push it to the server, or you can apply the patch if you want. I will continue my development for the Drupal module, so there may come more.
Regards,
Eelco
ckeditor-html5-video-1.patch
The text was updated successfully, but these errors were encountered: