-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should drop the polyfills in favor of native fetch or a newer library #169
Comments
Hi @thgreasi, @balena-ci I've encountered severe memory issues with Important Please let me know if you intend on continuing with your PR #185 , it looks close and it would be very helpful I would find if very helpful to use the native fetch version as it would allow me to use node-fetch v3 when operating in Node 20 or node 22, v3 has improved streaming handling capabilities which I believe would reduce the memory related issues I am seeing. As
Please let me know if you would like more details |
Hi, |
@thgreasi Thank you for your response, I'm happy to have a look at the tests myself when I get time |
Node 18 now has native fetch and webstreams are available since node 16.
On the other hand we might want to consider moving to a different more feature rich library like
got
.See: https://balena.zulipchat.com/#narrow/stream/346007-balena-io.2FbalenaCloud/topic/What.20we.20replace.20'request'.20with.3F
The text was updated successfully, but these errors were encountered: