From 87e58172da0d331ff2e386db695ea6dd197bd930 Mon Sep 17 00:00:00 2001 From: Steven Date: Sat, 24 Feb 2024 23:32:48 -0500 Subject: [PATCH 1/3] fix(general-info-step.tsx): added the min property to the numberinput 407 --- .../src/components/new-group-stepper/general-info-step.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/apps/dashboard/src/components/new-group-stepper/general-info-step.tsx b/apps/dashboard/src/components/new-group-stepper/general-info-step.tsx index 525d9696..efb2d38c 100644 --- a/apps/dashboard/src/components/new-group-stepper/general-info-step.tsx +++ b/apps/dashboard/src/components/new-group-stepper/general-info-step.tsx @@ -164,6 +164,7 @@ export default function GeneralInfoStep({ Fingerprint duration From 8d5d2ec9b15b97841f26b326625042f28b32627c Mon Sep 17 00:00:00 2001 From: Steven Date: Sat, 24 Feb 2024 23:38:57 -0500 Subject: [PATCH 2/3] fix(general-info-step): disabled the continue button when the fingerprintDuration is less that 0 Disabled the continue button because while the min property was in place there was still a loop hole to enter a value less that 0 407 --- .../src/components/new-group-stepper/general-info-step.tsx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/apps/dashboard/src/components/new-group-stepper/general-info-step.tsx b/apps/dashboard/src/components/new-group-stepper/general-info-step.tsx index efb2d38c..cd469623 100644 --- a/apps/dashboard/src/components/new-group-stepper/general-info-step.tsx +++ b/apps/dashboard/src/components/new-group-stepper/general-info-step.tsx @@ -207,7 +207,8 @@ export default function GeneralInfoStep({ _fingerprintDuration === undefined) || (group.type === "off-chain" && !_groupDescription) || (group.type === "off-chain" && - _groupDescription.length < 10) + _groupDescription.length < 10) || + (_fingerprintDuration < 0) } variant="solid" colorScheme="primary" From e3a7ecd5c1379d1b0b55d8e5d2a08a8ce644c81c Mon Sep 17 00:00:00 2001 From: Steven Date: Sat, 24 Feb 2024 23:41:54 -0500 Subject: [PATCH 3/3] fix(all files): ran prettier:write ran prettier:write 407 --- .../src/components/new-group-stepper/general-info-step.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/dashboard/src/components/new-group-stepper/general-info-step.tsx b/apps/dashboard/src/components/new-group-stepper/general-info-step.tsx index cd469623..73692114 100644 --- a/apps/dashboard/src/components/new-group-stepper/general-info-step.tsx +++ b/apps/dashboard/src/components/new-group-stepper/general-info-step.tsx @@ -208,7 +208,7 @@ export default function GeneralInfoStep({ (group.type === "off-chain" && !_groupDescription) || (group.type === "off-chain" && _groupDescription.length < 10) || - (_fingerprintDuration < 0) + _fingerprintDuration < 0 } variant="solid" colorScheme="primary"