-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optionally expose new metrics for AWS Spot Rebalance Recommendations #13
Comments
@gjtempleton Could you share your work? I need this feature too |
3 tasks
Thanks a lot, @gjtempleton ! |
@hcbraun Sorry, I realised on finally testing my implementation that I'd left a couple of early returns which would have meant the new metric wouldn't be exposed. I've updated this PR and published a Docker image available as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
AWS now provide a new metadata endpoint to (potentially) pre-warn of likely spot interruption on instances. Metrics on these rebalance recommendations along with the time they were generated are likely to be useful for cluster operators.
Describe the solution you'd like to see
The spot termination exporter to (potentially optionally) expose a number of new metrics:
Describe alternatives you've considered
A completely separate component scraping the relevant metadata endpoint (as it differs from the already scraped spot termination endpoint.) However this would result in running another daemonset alongside the existing one.
Additional context
I've already done most of the work to perform this scraping and metrics exposition on an internal fork of the project, happy to raise the PR to add this functionality to the wider project.
The text was updated successfully, but these errors were encountered: