Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitwebUrl doesn't use correct port #5

Open
bukzor opened this issue May 2, 2013 · 0 comments
Open

GitwebUrl doesn't use correct port #5

bukzor opened this issue May 2, 2013 · 0 comments

Comments

@bukzor
Copy link
Contributor

bukzor commented May 2, 2013

The reported GitwebUrl assumes that the service will always be on port 80. This is untrue. The -port input should be used to append a :$port to the domain name when the port is not 80.

Current behavior:

$ ./goit 
Usage of ./goit:
  -excludeRegexp="": Exlude paths from being listed
  -gitwebServer="localhost": Gitweb server's hostname
  -port="8080": Port to listen from
  -runServer=false: Run web server or just print repositories

$ ./goit  .
{"Name":"goit","Path":"/home/buck/trees/theirs/goit","RelativePath":"home/buck/trees/theirs/goit","GitwebUrl":"https://localhost?p=home/buck/trees/theirs/goit","Type":1}

Correct behavior:

$ ./goit  .
{"Name":"goit","Path":"/home/buck/trees/theirs/goit","RelativePath":"home/buck/trees/theirs/goit","GitwebUrl":"https://localhost:8080?p=home/buck/trees/theirs/goit","Type":1}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant