Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beware of malicious code injections to this repo #186

Open
wiz opened this issue Nov 30, 2018 · 3 comments
Open

Beware of malicious code injections to this repo #186

wiz opened this issue Nov 30, 2018 · 3 comments

Comments

@wiz
Copy link

wiz commented Nov 30, 2018

FYI the same person who injected malicious code into the event-stream module also tried to do the same to this module:

https://web.archive.org/web/20181126192134/https://github.com/right9ctrl/node-scrypt

Original issue here:
dominictarr/event-stream#116

It's clear this module is also used in crypto-currency wallet implementations - please be careful not to accept any PRs or grant permissions to untrusted third parties.

@demurgos
Copy link

Thanks for info, it's frightening.

For other people checking this repo: scrypt is now part of Node core. You should prefer the builtin crypto lib and avoid this repo (it is no longer maintained).

@fiws
Copy link

fiws commented Jan 30, 2019

I was surprised to find straight forward dedicated scrypt methods in node core: https://nodejs.org/api/crypto.html#crypto_crypto_scrypt_password_salt_keylen_options_callback

I was expecting to use 5 different methods in a stream just to get a hash. Not the case – can recommend.

This repo should be marked as deprecated imo.

@chrisveness
Copy link

scrypt-kdf provides a wrapper around the native Node.js OpenSSL scrypt implementation, with a similar interface to this repo.

The Node.js native implementation is just the low-level part of scrypt – for password storage & validation, it is necessary to include a salt and an HMAC hash of the scrypt-derived key, and to provide a verify function, which scrypt-kdf does (as this repo used to).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants