Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Cropping #86

Open
God-damnit-all opened this issue Nov 10, 2023 · 8 comments
Open

[FR] Cropping #86

God-damnit-all opened this issue Nov 10, 2023 · 8 comments
Labels
enhancement New feature or request

Comments

@God-damnit-all
Copy link

I'd really like the ability to use the mouse on the video playback area to specify a crop area, and perhaps fine-tune the selected area further by resizing a selection box and/or adjusting coordinate/size values for the cropping area on another part of the GUI.

@bartekmotyl
Copy link
Owner

Hmm, are you aware of the functionality of mouse middle-button on the timeline? It allows you to place begin/end markers which you can later fine-tune by dragging them.

@bartekmotyl bartekmotyl added the enhancement New feature or request label Nov 12, 2023
@God-damnit-all
Copy link
Author

What does that have to do with cropping the video? I'm not talking about timecodes, I'm talking about doing things like cutting off black borders.

@bartekmotyl
Copy link
Owner

Ah, OK, I miss read your first request. So you mean to crop the resulting video (in this case this would be possible only with re-encoding, of course). This indeed is not possible (yet).

@KoolKeith
Copy link

Please reject requests like these quicker. Sorry ImportTaste. go elsewhere.
The whole point of this project, to NOT re-encode videos. This is fantastic and absolutely cruicial in my opinion. I have searched a long time for a project like this. Re-Encoding = Not here please.

@God-damnit-all
Copy link
Author

God-damnit-all commented Nov 18, 2023

Please reject requests like these quicker. Sorry ImportTaste. go elsewhere. The whole point of this project, to NOT re-encode videos. This is fantastic and absolutely cruicial in my opinion. I have searched a long time for a project like this. Re-Encoding = Not here please.

Well aren't you a ray of sunshine.

@God-damnit-all
Copy link
Author

For the record, "screen cropping" is possible to do without re-encoding via the mkv container.

Even discounting that, I'm not exactly sure why you think an option to re-encode would require the removal of the option to not re-encode. LosslessCut, for example, is a project that supports doing both (but lossless is the default).

@bartekmotyl
Copy link
Owner

I do not think there is a reason to "reject" any requests instead of collecting them here as ideas.
I will probably not implement it (do not have much time for the project anyway, and even if I had, there are other improves reported that in my opinion are more useful) but maybe some other contributor would like to do so (@ImportTaste - you are invited 😄 )

For the record, "screen cropping" is possible to do without re-encoding via the mkv container.

Good to know, I didn't know that. I think that in the end re-encoding is not a problem, if you are interested in more complex features. In the end you as a user decide whether you use the option or not. But definitely, one of the major features of SVC is to offer cutting without re-encoding, so this will always be possible.

@KoolKeith
Copy link

KoolKeith commented Nov 18, 2023

Even discounting that, I'm not exactly sure why you think an option to re-encode would require the removal of the option to not re-encode. LosslessCut, for example, is a project that supports doing both (but lossless is the default).

You are right. I'm sorry for behaving like a gollum yesterday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants