Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review JSDoc comments @ffd8 #172

Open
4 tasks
ff6347 opened this issue Feb 21, 2017 · 1 comment
Open
4 tasks

Review JSDoc comments @ffd8 #172

ff6347 opened this issue Feb 21, 2017 · 1 comment
Assignees
@ffd8
Labels
enhancement

Comments

@ff6347
Copy link
Member

ff6347 commented Feb 21, 2017

  • color.js
  • constants.js
  • core.js
  • data.js
@ff6347
Copy link
Member Author

ff6347 commented Feb 21, 2017

Hi @ffd8 for the constants.js file there should be some changes. Having each constant as property defined makes no sense. Everything is a property of b. so actually we would need to change every comment. It is easier if we just go for @constant instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ffd8 ffd8

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ff6347 @ffd8