Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use everyItem or itemByRange instead of loops for better performance in core #51

Closed
ff6347 opened this issue Jul 7, 2016 · 3 comments
Closed
Assignees

Comments

@ff6347
Copy link
Member

ff6347 commented Jul 7, 2016

As mentioned in issue #44

@ff6347 ff6347 changed the title Use everyItem or itemByRange instead of loops for better performance in core m Use everyItem or itemByRange instead of loops for better performance in core Jul 7, 2016
@ff6347 ff6347 added this to the Basil 2 milestone Jul 7, 2016
@ff6347 ff6347 self-assigned this Jul 20, 2016
@ff6347
Copy link
Member Author

ff6347 commented Aug 22, 2016

I've been snooping around the source. Actually there are not a lot of for loops used to get elements. 👍 There are some forEach loops though. these can't be replaced by a everyitem() call. The everyItem or itemByRange can be used to set properties but there is no way to run a function on each item.

@b-g
Copy link
Member

b-g commented Aug 22, 2016

Many thanks for double checking this nitty gritty performance detail!! I guess we can close the issue then?

@ff6347
Copy link
Member Author

ff6347 commented Aug 22, 2016

Yes we can.

@ff6347 ff6347 closed this as completed Aug 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants