Fix NormalSimulator broadcasted output shapes #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…low-org#291) * Splines draft * update keras requirement * small improvements to error messages * add rq spline function * add spline transform * update searchsorted utils for jax also add padd util * update tests * add assert_allclose util for improved messages * parametrize transform for flow tests * update jacobian, jacobian trace, vjp, jvp, and corresponding usages and tests * fix imports, remove old jacobian and jvp, fix application in free form flow * improve logdet computation in free form flows * Fix comparison for symbolic tensors under tf * Add splines to twomoons notebook * improve pad utility * fix missing left edge in spline * fix inside mask edge case * explicitly set bias initializer * add better expand utility * small clean up, renaming * fix indexing, fix inside check * dump * fix sign of log jacobian for inverse pass in rq spline * fix parameter splitting for spline transform * improve readability * fix scale and shift trailing dimension * fix inverse pass return value * correctly choose bins once for each dimension, even for multi-dimensional inputs * run formatter * reduce searchsorted log spam * log backend used at setup * remove maximum message cache size * Improve warning message for jax searchsorted * Fix spline parameter binning for compiled contexts * update inverse transform same as forward * Update TwoMoons notebook with splines WIP [skip ci] * fix spline inverse call for out of bounds values * Add working splines --------- Co-authored-by: stefanradev93 <[email protected]>
|
Good spot, thanks for the fix! I refactored it a bit to use automatic broadcasting, please take a look and let me know if you are happy with those changes. |
|
Thanks, the refactor looks good. Happy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
NormalSimulatorused for testing seems to have unintended output shapes.The
meanandstdhad repeated values, corresponding to the number of observations.The PR:
The latter could be avoided if a summary network or adapter transform is chosen.