Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move continuous-time consistency model to experimental module. #301

Merged
merged 3 commits into from
Feb 7, 2025

Conversation

vpratz
Copy link
Collaborator

@vpratz vpratz commented Feb 7, 2025

Related to #256

As we have not extensively tested their behavior and I have observed subpar performance in some settings, we move this model class to experimental for further testing, to see whether it is ready for broader use, or whether it turns out to be too unstable to be practical.

Related to bayesflow-org#256

As we have not extensively tested their behavior and I have observed
subpar performance in some settings, we move this model class to
experimental for further testing, to see whether it is ready for
broader use, or whether it turns out to be too unstable to be practical.
@vpratz vpratz requested a review from stefanradev93 February 7, 2025 08:52
@vpratz
Copy link
Collaborator Author

vpratz commented Feb 7, 2025

@stefanradev93 How much structure do we want in the experimental module? For now I just used a single file inside the module, but if we want a more nested structure, I will move the files around accordingly.
How do we deal with examples/preliminary tests of experimental functionality? Do we want to include an experimental folder in the examples directory?

@stefanradev93
Copy link
Contributor

I think the structure is fine for now. As you suggest, I would include an experimental examples that are not visible on the landing page.

@vpratz
Copy link
Collaborator Author

vpratz commented Feb 7, 2025

Thanks for taking a look! have made the corresponding change...

@vpratz vpratz merged commit a12e7b3 into bayesflow-org:dev Feb 7, 2025
13 checks passed
@vpratz vpratz deleted the sccm-experimental branch February 7, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants