Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary dependencies #53

Open
francois-rozet opened this issue Dec 17, 2021 · 0 comments
Open

Unnecessary dependencies #53

francois-rozet opened this issue Dec 17, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@francois-rozet
Copy link

francois-rozet commented Dec 17, 2021 •
edited
Loading

Hello,

The dependencies matplotlib, tensorboard and tqdm are installed by setup.py (and environment.yml) even though they are not used by nflows. They should be removed.

nflows/setup.py

Lines 22 to 26 in ac0bf43

"matplotlib",
"numpy",
"tensorboard",
"torch",
"tqdm",

It should be noted that matplotlib is imported (but not used) here

nflows/nflows/nn/nde/made.py

Line 6 in 639c3a7

from matplotlib import pyplot as plt

@arturbekasov arturbekasov added the enhancement New feature or request label Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arturbekasov @francois-rozet