From a42b252808d04838d8476ddad11dc1aa26ae8173 Mon Sep 17 00:00:00 2001 From: Alex Eagle Date: Tue, 1 Aug 2023 08:39:01 -0700 Subject: [PATCH] chore(release): don't use bazelisk from npm (#618) GitHub's default action runners image now includes bazelisk on the machine, so we are free to call `bazel` commands and be safe knowing the right version of Bazel will run. A step before debugging why our npm package doesn't publish, likely not related, but @josephperrott points out we have some extra setup-node `uses` which is not desirable. --- .github/workflows/release.yaml | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index 92d551be..b65b5861 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -56,13 +56,6 @@ jobs: with: fetch-depth: 0 - - uses: actions/setup-node@v3 - with: - node-version: '14' - - - name: Install Bazelisk - run: npm --global install @bazel/bazelisk@latest - - name: Build ibazel run: bazel build //cmd/ibazel:ibazel --config release ${{ matrix.build_flags }} ${{ matrix.cpu_flag }} @@ -100,12 +93,6 @@ jobs: - uses: actions/download-artifact@v3 with: path: ./npm-staging/bin - - uses: actions/setup-node@v3 - with: - node-version: '14' - - - name: Install Bazelisk - run: npm --global install @bazel/bazelisk@latest - name: Prepare ibazel binaries working-directory: ./npm-staging/bin