Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.0.1] Error with use of $(rlocationpath) in Bazel 8.0.0 #24646

Closed
bazel-io opened this issue Dec 11, 2024 · 3 comments
Closed

[8.0.1] Error with use of $(rlocationpath) in Bazel 8.0.0 #24646

bazel-io opened this issue Dec 11, 2024 · 3 comments
Milestone
8.0.1 release blo...

Comments

@bazel-io
Copy link
Member

Forked from #24613
@bazel-io bazel-io added this to the 8.0.1 release blockers milestone Dec 11, 2024
@iancha1992 iancha1992 mentioned this issue Dec 11, 2024
Closed
@bazel-io
Copy link
Member Author

bazel-io commented Jan 9, 2025

Cherry-pick was attempted but there were merge conflicts in the following file(s). Please resolve manually.

src/main/java/com/google/devtools/build/lib/packages/semantics/BuildLanguageOptions.java
src/main/java/com/google/devtools/build/lib/rules/objc/ObjcStarlarkInternal.java
src/test/java/com/google/devtools/build/lib/packages/semantics/ConsistencyTest.java

cc: @bazelbuild/triage

@meteorcloudy
Copy link
Member

@fmeum Are we missing some changes?

@fmeum fmeum mentioned this issue Jan 9, 2025
Merged
@fmeum
Copy link
Collaborator

fmeum commented Jan 9, 2025

@fmeum Are we missing some changes?

I sent #24874. We were only missing unrelated changes that added semantics flags (Starlark set).

github-merge-queue bot pushed a commit that referenced this issue Jan 9, 2025
@fmeum
[8.0.1] Add and flip --incompatible_locations_prefers_executable (#…
bf72265 
…24874)

Work towards #11820
Fixes #20038
Fixes #23200
Fixes #24613

RELNOTES: Extra targets provided to `ctx.expand_location` now expand to
their executable (if any) instead of resulting in an error if they
provide a number of files different from one.

RELNOTES[INC]: The `--incompatible_locations_prefers_executable` flag
has been added and enabled, which makes it so that `ctx.expand_location`
expands `$(locations :x)` to the executable of an extra target `:x` if
it provides one and the number of files provided by it is not one.

Closes #24690.

PiperOrigin-RevId: 713453768
Change-Id: I0d6e052bc70deea029554ab722feb544f9597a23 
(cherry picked from commit 457d248)

Fixes #24646
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.0.1 release blockers
Development

No branches or pull requests
3 participants
@meteorcloudy @fmeum @bazel-io