Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.5.0] Add --inject_repository and fix crash on overridden non-existent repo #24679

Closed
bazel-io opened this issue Dec 13, 2024 · 3 comments
Closed

Comments

@bazel-io
Copy link
Member

Forked from #23791

@bazel-io bazel-io added this to the 7.5.0 release blockers milestone Dec 13, 2024
@bazel-io
Copy link
Member Author

Cherry-pick was attempted but there were merge conflicts in the following file(s). Please resolve manually.

src/main/java/com/google/devtools/build/lib/bazel/bzlmod/ModuleFileFunction.java
src/main/java/com/google/devtools/build/lib/bazel/bzlmod/ModuleFileGlobals.java
src/main/java/com/google/devtools/build/lib/skyframe/BUILD
src/test/java/com/google/devtools/build/lib/analysis/util/AnalysisTestCase.java
src/test/java/com/google/devtools/build/lib/pkgcache/IncrementalLoadingTest.java
src/test/java/com/google/devtools/build/lib/query2/testutil/BUILD
src/test/java/com/google/devtools/build/lib/skyframe/BUILD
src/test/java/com/google/devtools/build/lib/skyframe/ContainingPackageLookupFunctionTest.java
src/test/java/com/google/devtools/build/lib/skyframe/PackageLookupFunctionTest.java
src/test/shell/integration/aspect_test.sh

cc: @bazelbuild/triage

@iancha1992
Copy link
Member

Cherry-pick was attempted but there were merge conflicts in the following file(s). Please resolve manually.

src/main/java/com/google/devtools/build/lib/bazel/bzlmod/ModuleFileFunction.java src/main/java/com/google/devtools/build/lib/bazel/bzlmod/ModuleFileGlobals.java src/main/java/com/google/devtools/build/lib/skyframe/BUILD src/test/java/com/google/devtools/build/lib/analysis/util/AnalysisTestCase.java src/test/java/com/google/devtools/build/lib/pkgcache/IncrementalLoadingTest.java src/test/java/com/google/devtools/build/lib/query2/testutil/BUILD src/test/java/com/google/devtools/build/lib/skyframe/BUILD src/test/java/com/google/devtools/build/lib/skyframe/ContainingPackageLookupFunctionTest.java src/test/java/com/google/devtools/build/lib/skyframe/PackageLookupFunctionTest.java src/test/shell/integration/aspect_test.sh

cc: @bazelbuild/triage

cc: @fmeum @Wyverald @meteorcloudy

@fmeum
Copy link
Collaborator

fmeum commented Jan 9, 2025

That looks unrealistic to resolve.

@fmeum fmeum closed this as not planned Won't fix, can't repro, duplicate, stale Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants