Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.5.0] Remove empty coverage environment #24768

Closed
bazel-io opened this issue Dec 19, 2024 · 4 comments
Closed

[7.5.0] Remove empty coverage environment #24768

bazel-io opened this issue Dec 19, 2024 · 4 comments
Milestone
7.5.0 release blo...

Comments

@bazel-io
Copy link
Member

Forked from #24670
@bazel-io bazel-io added this to the 7.5.0 release blockers milestone Dec 19, 2024
@bazel-io
Copy link
Member Author

Cherry-pick was attempted but there were merge conflicts in the following file(s). Please resolve manually.

src/test/java/com/google/devtools/build/lib/rules/cpp/CcToolchainProviderTest.java

cc: @bazelbuild/triage

@iancha1992
Copy link
Member

Cherry-pick was attempted but there were merge conflicts in the following file(s). Please resolve manually.

src/test/java/com/google/devtools/build/lib/rules/cpp/CcToolchainProviderTest.java

cc: @bazelbuild/triage

cc: @keith @c-mita @comius @pzembrod @trybka

@keith
Copy link
Member

keith commented Jan 6, 2025 •
edited
Loading

I will manually submit this shortly

@keith keith mentioned this issue Jan 6, 2025
Merged
keith added a commit to keith/bazel that referenced this issue Jan 6, 2025
@keith
[7.5.0] Remove empty coverage environment
4c1eb16 
Fixes bazelbuild#23247

Closes bazelbuild#24768

PiperOrigin-RevId: 707176116
Change-Id: I71ef3c630f8130467cc6a0c730c1278ae6b0817f
(cherry picked from commit 03eae37)
@keith
Copy link
Member

keith commented Jan 6, 2025

i had to adapt the tests, #24835

meteorcloudy pushed a commit that referenced this issue Jan 8, 2025
@keith
[7.5.0] Remove empty coverage environment (#24835)
b9c7111 
Fixes #23247

Closes #24768

PiperOrigin-RevId: 707176116
Change-Id: I71ef3c630f8130467cc6a0c730c1278ae6b0817f
(cherry picked from commit 03eae37)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.5.0 release blockers
Development

No branches or pull requests
3 participants
@keith @bazel-io @iancha1992