-
-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bazel CI] Error in glob: glob pattern 'lib/clang/*/lib/**/*.dylib' didn't match anything #540
Comments
@marvin-hansen Are you able to take a look at the test failures of the rust examples with Bazel@HEAD? See the latest build result from https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/4431#_ If not, we'll have to skip those tests in bazel downstream pipeline. |
Okay, I take a look over the upcoming weekend. |
Okay, I've filled the first PR that renovates Rust example 1-3. For some totally stupid reasons, I managed to carry over the commit history from 6 months ago to the new branch prior to the merge of the current head. This is totally on me, I get it, but on the bright side, these seem to fix some other examples so please take a look if you are able/willing to review the PR. |
PR's: Fix for examples 1 - 3: #546 If I read the tealeaves correctly, then CI in the last PR is green with all Rust examples passing |
Last batch of fixed up Rust examples. Example 8 got a major makeover b/c the latest rules_rust separated into multiple sub-modules, which required quite some refactoring. Resolves #540 --------- Signed-off-by: Marvin Hansen <[email protected]>
The rust examples are still failing with Bazel@HEAD:
I guess this is because the Bazel binary built from HEAD doesn't have a version number? |
Okay, I debug this with Bazel nightly and try to figure out what's happening. Sorry for this but in the past Bazel 8 was really consistent with rules_rust so apparently some major cheese got moved... |
Here are the latest CI failures in Bazel Examples |
I see, it seems that the generated vendor script can't digest the missing Bazel version number. Let me ask over at the rules_rust slack and see what can be done. The good news is, all the remaining examples fail for the exact same reason so once that is patched, downstream CI on HEAD should be green again. |
Okay, there are two offending examples: 7 and 8. For example 8, I resolved the problem by removing the vendoring that causes the build failure. Example 7 is really tricky b/c it basically showcases the vendoring that generates the script that |
The other thing is, I could not replicate the error on nightly Would it be sensible to exclude example 7 from downstream b/c it really is a quite a corner case? |
Fixes Rust example 8 on downstream CI, as discussed in #540 Replaces the previous PR #554 Signed-off-by: Marvin Hansen <[email protected]>
The fix for Rust example 8 was merged so I suggest removing example 7 from downstream CI and then to close this issue. |
CI: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/4381#01943ef5-b088-4c02-a5ba-2aa30cdd04f3
Platform: Ubuntu
Logs:
Steps:
CC Greenteam @Wyverald
The text was updated successfully, but these errors were encountered: