Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stardoc fails on rules consuming rules_cc v0.0.17 #279

Open
UebelAndre opened this issue Nov 26, 2024 · 3 comments
Open

Stardoc fails on rules consuming rules_cc v0.0.17 #279

UebelAndre opened this issue Nov 26, 2024 · 3 comments

Comments

@UebelAndre
Copy link
Contributor

UebelAndre commented Nov 26, 2024 •
edited
Loading

Description of the problem / feature request:

stardoc fails on
https://buildkite.com/bazel/rules-rust-rustlang/builds/12779#01936a34-f496-43e9-9f62-e905a5d685b7

ERROR: /workdir/docs/BUILD.bazel:175:8: in deps attribute of starlark_doc_extract rule //:rust_bindgen.extract: missing bzl_library targets for Starlark module(s) @@protobuf~//bazel:cc_proto_library.bzl, @@rules_cc~//cc/common:cc_common.bzl, @@rules_cc~//cc/common:cc_info.bzl, @@rules_cc~//cc/common:debug_package_info.bzl, @@rules_cc~//cc/toolchains:cc_flags_supplier.bzl, @@rules_cc~//cc/toolchains:cc_toolchain.bzl, @@rules_cc~//cc/toolchains:cc_toolchain_config_info.bzl, @@rules_cc~//cc/toolchains:cc_toolchain_suite.bzl, @@rules_cc~//cc/toolchains:compiler_flag.bzl, @@rules_cc~//cc/toolchains:fdo_prefetch_hints.bzl, @@rules_cc~//cc/toolchains:fdo_profile.bzl. Since this rule was created by the macro 'stardoc', the error might have been caused by the macro implementation

We used to not have this issue in rules_rust but after attempting to upgrade we can no longer generate docs.

Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

Try running stardoc on rules_cc.

What operating system are you running Bazel on?

Linux, Windows, MacOS

What's the output of bazel info release?

7.4.1

What version of rules_cc do you use? Can you paste the workspace rule used to fetch rules_cc? What other relevant dependencies does your project have?

rules_cc: 0.0.17
@pzembrod
Copy link
Collaborator

@hlopko fyi

@cloudhan
Copy link

Same here for rules_cuda

cloudhan added a commit to bazel-contrib/rules_cuda that referenced this issue Feb 12, 2025
@cloudhan
fix(docs): partially fix docs gen, still experience bazelbuild/rules_…
185bf4c 
…cc#279
cloudhan added a commit to bazel-contrib/rules_cuda that referenced this issue Feb 13, 2025
@cloudhan
fix(docs): partially fix docs gen, still experience bazelbuild/rules_…
5af8dcc 
…cc#279
cloudhan added a commit to bazel-contrib/rules_cuda that referenced this issue Feb 13, 2025
@cloudhan
fix(ci): fix ci pipelines prior updating dependency bazel to v8 (#320)
6a6d2f1 
* fix(docs): partially fix docs gen, still experience bazelbuild/rules_cc#279

* ci: copy-pasting for new version due to flag change

* fix: explicit allow_empty for glob
cloudhan added a commit to bazel-contrib/rules_cuda that referenced this issue Feb 24, 2025
@cloudhan
chore(deps): update dependency bazel to v8
5b47069 
and with fix docs/.bazelversion to 7.5.0 due to bazelbuild/rules_cc#279
@cloudhan cloudhan mentioned this issue Feb 24, 2025
Merged
@cloudhan
Copy link

With 0.1.1, the problem still presents.

cloudhan added a commit to bazel-contrib/rules_cuda that referenced this issue Feb 24, 2025
@cloudhan
chore(deps): update dependency bazel to v8 (#328)
d8aaded 
and fix docs/.bazelversion to 7.5.0 due to bazelbuild/rules_cc#279
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cloudhan @pzembrod @UebelAndre