Executable mode is lost on executables added via tree to pkg_tar

[peakschris]

When we add a tree to pkg_tar via pkg_files, some files being executable and some not, the executable file modes are lost due to this line:

rules_pkg/pkg/mappings.bzl

Line 258 in a56b1d9

out_attributes.setdefault("mode", "0644")

pkg_tar has some code to carry-over executable modes from the underlying files, but this is only active when mode = None, and the above line results in mode always being set explicitly to a default value.

There is no other UI to allow control over executable mode for specific files in tree artifacts.

[aiuto]

Have you tried the "attributes" setting on pkg_files. https://bazelbuild.github.io/rules_pkg/latest.html#pkg_files-attributes