Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proto_common.compile breaks non-.exe Windows plugins #220

Open
iamricard opened this issue Jul 3, 2024 · 0 comments
Open

proto_common.compile breaks non-.exe Windows plugins #220

iamricard opened this issue Jul 3, 2024 · 0 comments
Labels
P3 We're not considering to work on this, but happy to review a PR. (No assignee)

Comments

@iamricard
Copy link

When using proto_common.compile on a Windows host the resulting path passed to plugin_format_flag uses forward slashes. This is fine for .exe, but it breaks for .bat plugins. It seems that because .exe plugins don't use the cmd.exe wrapper Windows can handle them just fine, but plugins with .bat (eg. a js_binary from rules_js) break with an error like 'bazel-out' is not recognized as an internal or external command, operable program or batch file.

Ideally either proto_common.compile or protoc itself would rewrite the plugin path with backslashes as described in https://bazel.build/rules/windows#paths when running on Windows.

cc @Yannic

@comius comius added the P3 We're not considering to work on this, but happy to review a PR. (No assignee) label Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 We're not considering to work on this, but happy to review a PR. (No assignee)
Projects
None yet
Development

No branches or pull requests

2 participants