setup_scala_testing_toolchain() failing when passed xxx_classpath

[crt-31]

setup_scala_testing_toolchain() is failing when passing a custom set of labels as the scalatest_classpath argument.

If I pass in a classpath that has "@maven//:org_scalatest_scalatest_shouldmatchers_2_13", I am getting error:
target

'org_scalatest_scalatest_shouldmatchers_2_13_2_13_14' not declared in package.

It seems to be caused by the 'repositories()' function here:

rules_scala/testing/testing.bzl

Line 38 in 58dfbc7

repositories(scala_version, junit_classpath),

I believe it shouldn't be calling that repositories() mapping and just use the passed in labels as they are.

Code: master on (2/24/2025)

[mbland]

Thanks for catching this. I guess we don't have an existing test for this, and I made this change a few months ago. Given my experience at this point, I think you're right about those repositories calls in setup_scala_testing_toolchain() . They belong in scala_toolchains() somewhere, most likely, and will require a change to //scala:toolchains_repo.bzl as well.

I'm happy to try to cook up a test to reproduce this, then apply a fix.