Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

retools.queue butchers queue names #41

Open
msabramo opened this issue Nov 7, 2014 · 0 comments · Fixed by #42
Open

retools.queue butchers queue names #41

msabramo opened this issue Nov 7, 2014 · 0 comments · Fixed by #42

Comments

@msabramo
Copy link
Contributor

msabramo commented Nov 7, 2014

I use a queue named "long" and I noticed that the process title was always "retools: Waiting for ng" for some strange reason.

Tonight, I finally looked into it and found out why.

It's because lstrip doesn't do what the author of the code who used it thinks it does.

>>> queue_name = 'long'
>>> queue_name.lstrip('retools:queue:')
'ng'

This inappropriate usage is in 2 places:

I'll send a PR to fix this...
msabramo added a commit to msabramo/retools that referenced this issue Nov 7, 2014
@msabramo
Eliminate 2 incorrect uses of lstrip
838424d 
One of them, in Worker.queue_names caused the queue names for worker
processes to get butchered -- e.g.: "long" => "ng"

Fixes: bbangertGH-41
@msabramo msabramo mentioned this issue Nov 7, 2014
Merged
bbangert added a commit that referenced this issue Nov 12, 2014
@bbangert
Merge pull request #42 from msabramo/issues/GH-41
779ba6c 
Eliminate 2 incorrect uses of lstrip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Eliminate 2 incorrect uses of lstrip msabramo/retools
1 participant
@msabramo