🐛 [BUG]: Cannot add data-* attributes to BaseEdge

[alexgrozav]

Is there an existing issue for this?

• I have searched the existing issues and this is a new bug.

Current Behavior

BaseEdge does not render data-* attributes such as data-test-id.

Expected Behavior

BaseEdge should render any data-* attribute you pass to it.

Steps To Reproduce

1. Create custom edge
2. Add data-* attributes such as data-test-id to it.

Minimal reproduction of the issue with CodeSandbox

No response

Relevant log output

No response

Anything else?

[bcakmakoglu]

I don't see why this is a "bug".
The BaseEdge doesn't inherit attributes since it renders a fragment with two paths (one for the visible path and one for an invisible overlay for better interaction purposes).
If you need to add some test id why not just wrap it and add the id to the wrapper?

<g data-test-id="my-test-id">
	<BaseEdge .../>
</g>

[bcakmakoglu]

I can offer to refactor the BaseEdge to inherit attributes on it's main path element.
You won't be able to add these attributes to the secondary interaction path element though (which I don't think you'll need anyway and if you do you can select it with a querySelector instead).

[alexgrozav]

I'll see if I can get around it with wrapping. Thank you for the suggestion!

[alexgrozav]

Thank you! That worked perfectly. Somehow, I didn't realize I can use an svg group for that, learned something new today.

Feel free to close this since it has a simple workaround.

[bcakmakoglu]

I'll still allow binding attrs to the base edge main element since that makes sense.
This change will be released in the next minor :)

[bcakmakoglu]

Fix released with 1.42.0