From 1eb0e5e6a50294a1fdc85d42b0072acd99a7650c Mon Sep 17 00:00:00 2001 From: Rafael Solorzano <61289255+rafasdc@users.noreply.github.com> Date: Fri, 18 Oct 2024 13:49:58 -0700 Subject: [PATCH 1/2] fix: sow tab 7 total estimated project cost not importing --- app/backend/lib/sow_import/tab_7.ts | 2 +- app/tests/backend/lib/sow_tab_7.test.ts | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/backend/lib/sow_import/tab_7.ts b/app/backend/lib/sow_import/tab_7.ts index 1ba511abe..2557d7394 100644 --- a/app/backend/lib/sow_import/tab_7.ts +++ b/app/backend/lib/sow_import/tab_7.ts @@ -265,7 +265,7 @@ const readBudget = async (sow_id, wb, sheet_name) => { // -- SUMMARY OF ESTIMATED PROJECT COSTS -- // first pass - column B - for (let row = 1000; row < 1075; row++) { + for (let row = 1000; row < 1076; row++) { const suspect = budget[row]['B']; let value; if (suspect === undefined) continue; diff --git a/app/tests/backend/lib/sow_tab_7.test.ts b/app/tests/backend/lib/sow_tab_7.test.ts index 4e4c927b5..763034602 100644 --- a/app/tests/backend/lib/sow_tab_7.test.ts +++ b/app/tests/backend/lib/sow_tab_7.test.ts @@ -1787,7 +1787,7 @@ describe('sow tab 7 tests', () => { eligibleMobile: 0, totalEligibleCosts: 500000, totalIneligibleCosts: 250000, - totalProjectCost: '', + totalProjectCost: 750000, }, totalCostsPerCostCategory: { directLabour: { cost: 80000, percentOfTotalEligibleCosts: 0.16 }, @@ -2015,7 +2015,7 @@ describe('sow tab 7 tests', () => { eligibleMobile: 0, totalEligibleCosts: 500000, totalIneligibleCosts: 250000, - totalProjectCost: '', + totalProjectCost: 750000, }, totalCostsPerCostCategory: { directLabour: { cost: 80000, percentOfTotalEligibleCosts: 0.16 }, From 051d8c1c58c6ff4e0e56f0866e9e75d5bc1205d0 Mon Sep 17 00:00:00 2001 From: CCBC Service Account <116113628+ccbc-service-account@users.noreply.github.com> Date: Wed, 23 Oct 2024 20:54:17 +0000 Subject: [PATCH 2/2] chore: release v1.202.2 --- CHANGELOG.md | 6 ++++++ db/sqitch.plan | 1 + package.json | 2 +- 3 files changed, 8 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e1770f76c..7a75c6a72 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,9 @@ +## [1.202.2](https://github.com/bcgov/CONN-CCBC-portal/compare/v1.202.1...v1.202.2) (2024-10-23) + +### Bug Fixes + +- sow tab 7 total estimated project cost not importing ([1eb0e5e](https://github.com/bcgov/CONN-CCBC-portal/commit/1eb0e5e6a50294a1fdc85d42b0072acd99a7650c)) + ## [1.202.1](https://github.com/bcgov/CONN-CCBC-portal/compare/v1.202.0...v1.202.1) (2024-10-23) ### Bug Fixes diff --git a/db/sqitch.plan b/db/sqitch.plan index e98fda7d1..5d05c0bdd 100644 --- a/db/sqitch.plan +++ b/db/sqitch.plan @@ -714,3 +714,4 @@ tables/application_form_template_9_data 2024-09-25T22:50:17Z Rafael Solorzano <6 @1.201.1 2024-10-18T23:48:24Z CCBC Service Account # release v1.201.1 @1.202.0 2024-10-21T21:32:01Z CCBC Service Account # release v1.202.0 @1.202.1 2024-10-23T14:59:42Z CCBC Service Account # release v1.202.1 +@1.202.2 2024-10-23T20:54:15Z CCBC Service Account # release v1.202.2 diff --git a/package.json b/package.json index 55a3c9305..c577c52cb 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "CONN-CCBC-portal", - "version": "1.202.1", + "version": "1.202.2", "main": "index.js", "repository": "https://github.com/bcgov/CONN-CCBC-portal.git", "author": "Romer, Meherzad CITZ:EX ",