From 08232e368d2e424df126d88605800000a2cc2fcc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9verin=20Beauvais?= Date: Wed, 21 Sep 2022 11:48:46 -0700 Subject: [PATCH] 6168 Refactor Todo List (#388) * - app version = 5.6.0 * - added "protected" to lifecycle methods - removed conflicting Getters, States, Actions * - moved Details List to FilingHistoryList folder - fixed button colours - removed obsolete Add Comment Dialog from Todo List - cleaned up expansion panel header blocks - deleted draft correction duplicate View Details button - deleted obsolete Details button from alteration in good standing - deleted obsolete comments and commentsLink item properties - deleted unneeded togglePanel() - removed todo task references from Details List - added CorrectionComment component and plumbing - misc cleanup * - more cleanup --- package-lock.json | 4 +- package.json | 2 +- src/App.vue | 11 +- src/assets/styles/base.scss | 18 - .../Dashboard/FilingHistoryList.vue | 38 +- .../FilingHistoryList}/DetailsList.vue | 14 +- src/components/Dashboard/StaffNotation.vue | 22 +- src/components/Dashboard/TodoList.vue | 434 ++++++++---------- .../{ => TodoList}/ActionRequired.vue | 4 +- .../Dashboard/TodoList/CorrectionComment.vue | 22 + src/components/EntityInfo.vue | 5 +- src/components/common/Certify.vue | 2 +- src/components/common/DetailComment.vue | 2 +- src/components/common/NameRequestInfo.vue | 2 +- src/components/common/OfficeAddresses.vue | 2 +- src/components/common/index.ts | 2 - src/components/dialogs/AddCommentDialog.vue | 16 +- .../dialogs/AddStaffNotationDialog.vue | 2 +- ...ution.vue => ConfirmDissolutionDialog.vue} | 10 +- src/components/dialogs/index.ts | 4 +- src/interfaces/todo-item-interface.ts | 6 +- src/views/AnnualReport.vue | 5 +- src/views/Correction.vue | 14 +- src/views/StandaloneDirectorsFiling.vue | 18 +- src/views/StandaloneOfficeAddressFiling.vue | 18 +- src/views/auth/Signin.vue | 3 +- tests/unit/ActionRequired.spec.ts | 2 +- ...ec.ts => ConfirmDissolutionDialog.spec.ts} | 10 +- tests/unit/CorrectionComment.spec.ts | 36 ++ tests/unit/DetailsList.spec.ts | 38 +- tests/unit/FilingHistoryList1.spec.ts | 2 +- tests/unit/TodoList1.spec.ts | 28 +- tests/unit/TodoList2.spec.ts | 2 +- 33 files changed, 379 insertions(+), 419 deletions(-) rename src/components/{common => Dashboard/FilingHistoryList}/DetailsList.vue (79%) rename src/components/Dashboard/{ => TodoList}/ActionRequired.vue (88%) create mode 100644 src/components/Dashboard/TodoList/CorrectionComment.vue rename src/components/dialogs/{ConfirmDissolution.vue => ConfirmDissolutionDialog.vue} (94%) rename tests/unit/{ConfirmDissolution.spec.ts => ConfirmDissolutionDialog.spec.ts} (92%) create mode 100644 tests/unit/CorrectionComment.spec.ts diff --git a/package-lock.json b/package-lock.json index eb1c070f9..f3bc2a6c1 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "business-filings-ui", - "version": "5.5.2", + "version": "5.6.0", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "business-filings-ui", - "version": "5.5.2", + "version": "5.6.0", "dependencies": { "@babel/compat-data": "^7.11.0", "@bcrs-shared-components/bread-crumb": "1.0.8", diff --git a/package.json b/package.json index 933c098da..16c4735f0 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "business-filings-ui", - "version": "5.5.2", + "version": "5.6.0", "private": true, "appName": "Filings UI", "sbcName": "SBC Common Components", diff --git a/src/App.vue b/src/App.vue index 6be4e54f8..53aac9fd2 100644 --- a/src/App.vue +++ b/src/App.vue @@ -36,7 +36,7 @@ attach="#app" /> -
- + - mdi-information-outline + mdi-information-outline {{(panel === index) ? "Hide Details" : "View Details"}}
@@ -108,7 +108,7 @@ :ripple=false @click.stop="togglePanel(index, filing)" > - mdi-alert + mdi-alert {{(panel === index) ? "Hide Details" : "View Details"}} @@ -127,11 +127,11 @@ - mdi-information-outline + mdi-information-outline {{(panel === index) ? "Hide Details" : "View Details"}} @@ -148,7 +148,7 @@ :ripple=false @click.stop="togglePanel(index, filing)" > - mdi-alert + mdi-alert {{(panel === index) ? "Hide Details" : "View Details"}} @@ -168,7 +168,7 @@ :ripple=false @click.stop="togglePanel(index, filing)" > - mdi-message-reply + mdi-message-reply Detail{{filing.commentsCount > 1 ? "s" : ""}} ({{filing.commentsCount}}) @@ -205,7 +205,7 @@ - mdi-file-document-edit-outline + mdi-file-document-edit-outline - mdi-comment-plus + mdi-comment-plus @@ -328,7 +327,7 @@ - +