From d0995e832ee1a95c1c0c4eeda9fae6818df48c9d Mon Sep 17 00:00:00 2001 From: ritvick Date: Mon, 27 Jun 2022 20:38:45 -0400 Subject: [PATCH 1/3] Feature 12775 - Add details to dissolution shema --- src/registry_schemas/schemas/dissolution.json | 3 +++ tests/unit/test_dissolution.py | 15 +++++++++++++++ 2 files changed, 18 insertions(+) diff --git a/src/registry_schemas/schemas/dissolution.json b/src/registry_schemas/schemas/dissolution.json index 49bebd6..70a5239 100644 --- a/src/registry_schemas/schemas/dissolution.json +++ b/src/registry_schemas/schemas/dissolution.json @@ -30,6 +30,9 @@ "courtOrderedLiquidation" ] }, + "details": { + "type": "string" + }, "dissolutionStatementType": { "type": "string" }, diff --git a/tests/unit/test_dissolution.py b/tests/unit/test_dissolution.py index 8bf5d76..9a6af4a 100644 --- a/tests/unit/test_dissolution.py +++ b/tests/unit/test_dissolution.py @@ -83,6 +83,21 @@ def test_dissolution_court_order(): assert is_valid +def test_administrative_dissolution_schema(): + """Assert that the JSONSchema validator is working.""" + legal_filing = {'dissolution': copy.deepcopy(DISSOLUTION)} + legal_filing['dissolution']['dissolutionType'] = 'administrative' + legal_filing['dissolution']['details'] = 'Some Details' + + is_valid, errors = validate(legal_filing, 'dissolution') + + if errors: + for err in errors: + print(err.message) + print(errors) + + assert is_valid + @pytest.mark.parametrize('invalid_court_order', [ *[{'orderDate': '2021-01-30T09:56:01+08:00', From 7b4aceb8988e9a7b6afb2571c1b61fa3dc050188 Mon Sep 17 00:00:00 2001 From: ritvick Date: Mon, 27 Jun 2022 20:41:44 -0400 Subject: [PATCH 2/3] version changes --- src/registry_schemas/version.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/registry_schemas/version.py b/src/registry_schemas/version.py index 31220f6..ec6468e 100644 --- a/src/registry_schemas/version.py +++ b/src/registry_schemas/version.py @@ -22,4 +22,4 @@ Development release segment: .devN """ -__version__ = '2.15.24' # pylint: disable=invalid-name +__version__ = '2.15.25' # pylint: disable=invalid-name From f316cbe14a8e032519495842d1e57371e461fbcb Mon Sep 17 00:00:00 2001 From: ritvick Date: Tue, 28 Jun 2022 17:54:58 -0400 Subject: [PATCH 3/3] review comments --- src/registry_schemas/schemas/dissolution.json | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/registry_schemas/schemas/dissolution.json b/src/registry_schemas/schemas/dissolution.json index 70a5239..ef61132 100644 --- a/src/registry_schemas/schemas/dissolution.json +++ b/src/registry_schemas/schemas/dissolution.json @@ -31,7 +31,9 @@ ] }, "details": { - "type": "string" + "type": "string", + "minLength": 0, + "maxLength": 2000 }, "dissolutionStatementType": { "type": "string"