Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LCFS - Patch IA transaction history and progress bar #2090

Open
3 tasks
Grulin opened this issue Feb 24, 2025 · 2 comments
Open
3 tasks

LCFS - Patch IA transaction history and progress bar #2090

Grulin opened this issue Feb 24, 2025 · 2 comments
Assignees
Labels
High High priority ticket but not critical at this time Task Work that does not directly impact the user

Comments

@Grulin
Copy link
Collaborator

Grulin commented Feb 24, 2025

Describe the task

  1. On the IDIR side, legacy IA transactions are now showing the transactions history stamp of "Approved" by the director. It is incorrectly showing that the analyst approved the transaction. It should show that the analyst recommended the transaction and the director approved it. BCeID side should only show that the director approved it.

  2. 2019-2023 transactions and 2024 and beyond transactions are both showing an incorrect order in the progress bar at the top of the transaction. It is currently showing Draft>Approved>Recommended, when it should be showing Draft>Recommended>Approved

Purpose
This is important for record keeping purposes and UX clarity.

Acceptance Criteria

  • Ensure that the transaction history of the legacy IA transactions is correctly showing analyst recommended and director approved.
  • Fix the order of the status bar to display the order as Draft>Recommended>Approved
  • Double check that these transactions are not showing analyst or director names on the BCeID view side of the transaction. Only approval by the director.

Additional context

@Grulin Grulin added High High priority ticket but not critical at this time Task Work that does not directly impact the user labels Feb 24, 2025
@dhaselhan dhaselhan self-assigned this Feb 26, 2025
@dhaselhan
Copy link
Collaborator

dhaselhan commented Feb 26, 2025

real cause for the issue: A lot of these agreements don't have any recommended status in TFRS, they only have recorded and approved so no recommended status was transferred over.

Was able to figure out the issue with the history being out of order, some code was added that if the history of the initiative did not match our statuses, the UI would update accordingly, however we didn't expect to have missing records. We can remove this code but I am unsure of why it was added and I can't look up who because our code base is squashed.

@Grulin
Copy link
Collaborator Author

Grulin commented Feb 27, 2025

If approved, get rid of recommended

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High High priority ticket but not critical at this time Task Work that does not directly impact the user
Projects
None yet
Development

No branches or pull requests

2 participants