Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update colour tokens names #170

Open
jackwingsam opened this issue May 6, 2024 · 0 comments
Open

Update colour tokens names #170

jackwingsam opened this issue May 6, 2024 · 0 comments
Assignees
@jackwingsam

Comments

@jackwingsam
Copy link
Collaborator

jackwingsam commented May 6, 2024 •
edited
Loading

  1. Change Violet to Purple
  2. Pink to Magenta
  3. Lime green to Lime

We already have problems with violet and pink and have to override them.
https://github.com/bcgov/nr-theme/blob/main/design-tokens/light-tags.scss

For Lime green, update Figma library to reflect Github's token names.

This change will line up with Carbon's current token names.
https://carbondesignsystem.com/elements/color/tokens/
@jackwingsam jackwingsam moved this to Backlog in NR-theme May 6, 2024
@jackwingsam jackwingsam changed the title Change colour tokens from Violet to Purple and Pink to Magenta Change colour tokens names May 6, 2024
@jackwingsam jackwingsam changed the title Change colour tokens names Update colour tokens names May 6, 2024
@jackwingsam jackwingsam self-assigned this May 6, 2024
@jackwingsam jackwingsam moved this from Backlog to To be reviewed in Figma in NR-theme May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jackwingsam jackwingsam

Labels
None yet
Projects
NR-theme
Status: To be reviewed in Figma
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jackwingsam