We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
35.6.0
NET 8.0.400
Rider 2024.1.4
Windows
en_GB
Some phone numbers generated by Faker.Phone.PhoneNumber() when using the en_GB locale are invalid
using Bogus; using PhoneNumbers; void Main() { while(true) { var faker = new Faker("en_GB"); string phoneNumber = faker.Phone.PhoneNumber(); PhoneNumberUtil? phoneNumberUtil = PhoneNumberUtil.GetInstance(); PhoneNumbers.PhoneNumber? parsedPhoneNumber = phoneNumberUtil.Parse(phoneNumber, "GB"); if (!phoneNumberUtil.IsValidNumberForRegion(parsedPhoneNumber, "GB")) { throw new Exception("Invalid phone number " + phoneNumber); } } }
All UK phone numbers generated by faker.Phone.PhoneNumber(); should be valid.
faker.Phone.PhoneNumber();
See Google's libPhoneNumber: https://github.com/google/libphonenumber/blob/master/resources/PhoneNumberMetadata.xml#L11093
faker.Phone.PhoneNumber(); sometimes generates invalid UK phone numbers, such as:
Faker.Phone.PhoneNumber("07#########") is a suitable workaround.
Faker.Phone.PhoneNumber("07#########")
No
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Bogus NuGet Package
35.6.0
.NET Version
NET 8.0.400
Visual Studio Version
Rider 2024.1.4
What operating system are you using?
Windows
What locale are you using with Bogus?
en_GB
Problem Description
Some phone numbers generated by Faker.Phone.PhoneNumber() when using the en_GB locale are invalid
LINQPad Example or Reproduction Steps
Expected Behavior
All UK phone numbers generated by
faker.Phone.PhoneNumber();
should be valid.See Google's libPhoneNumber: https://github.com/google/libphonenumber/blob/master/resources/PhoneNumberMetadata.xml#L11093
Actual Behavior
faker.Phone.PhoneNumber();
sometimes generates invalid UK phone numbers, such as:Known Workarounds
Faker.Phone.PhoneNumber("07#########")
is a suitable workaround.Could you help with a pull-request?
No
The text was updated successfully, but these errors were encountered: